I noticed that in the latest DEV release, textimage_image_from_preset() now takes the preset array as the first parameter, rather than a preset identifier (i.e. preset name or numeric identifier), yet _textimage_preset_load() is still prefixed with an underscore to indicate that it is not intended to be used outside the module.

I would like to request that it be made a public function, just like textimage_image_from_preset(), so that other modules can depend on it to perform the necessary loading of the preset array that textimage_image_from_preset() requires. If the logic in the _textimage_preset_load() function is currently considered not "safe" to be used publicly by other modules, I think the necessary checks should be added to it to make it safe.

Alternatively, I would change textimage_image_from_preset() back to taking a preset identifier. I was actually surprised to see that the parameters on a public function like that would change between minor versions -- typically, Drupal policy is that you shouldn't have major API changes if the version is only from x.1 -> x.2 (i.e. 6.x-2.1 to 6.x-2.2), only if it was 1.x -> 2.x (i.e. 6.x-2.1 to 6.x-3.0).

Comments

mondrake’s picture

Issue summary: View changes
Status: Active » Closed (outdated)