$replace A boolean indicating whether an existing file of the same name in the destination directory should overwritten. A false value will generate a new, unique filename in the destination directory.
The parameter is not actually a boolean, but rather an enumerator (reported by alpapan).
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | file_save_upload_new3_841134_D6_0.patch | 2.04 KB | jhodgdon |
| #8 | file_save_upload_new3_841134_D6.patch | 2.04 KB | daniels220 |
| #7 | file_save_upload_new3_841134_D6.patch | 2.04 KB | daniels220 |
| #5 | file_save_upload_new_841134_D6.patch | 1.45 KB | daniels220 |
| #3 | file_save_upload_841134_D6.patch | 1.46 KB | daniels220 |
Comments
Comment #1
jhodgdonGood catch. This is only a problem in Drupal 6, not Drupal 7. Also, it's related to (but not a duplicate of):
#373606: file.inc documentation needs overhaul
Comment #2
jhodgdonThis particular fix would be a good project for a novice contributor. Just need to copy what's in Drupal 7 for this function to Drupal 6.
Comment #3
daniels220 commentedHere's a patch. I fixed up a couple other style issues in this function's doc as well.
An optional associative array...to(optional) An associative array...Added a blank line before @return.
Comment #4
jhodgdonI cannot get this patch to apply to D6 dev branch.
Also, if you are fixing up this function docblock, you could make it so the first line is a one-sentence summary, followed by a blank line?
Comment #5
daniels220 commentedProblems on my end sorted out, I think. Here's a new patch.
Comment #6
jhodgdonApplies and looks good, but it still doesn't bring the docblock into compliance, where the first line is a one-sentence summary, and it's followed by a newline and perhaps more description.
Comment #7
daniels220 commentedWhoops, I think I accidentally git reset'ed myself and didn't redo all my changes. Fixed by just moving the second sentence into the long description.
Comment #8
daniels220 commentedWhoops, I think I accidentally git reset'ed myself and didn't redo all my changes. Fixed by just moving the second sentence into the long description.
Comment #9
daniels220 commentedSorry for the double submit.
Comment #10
jhodgdonNitpick: There is a trailing space on the 2nd line. Other than that, the patch is good... To save time, I removed that space from the patch and here it is.
Comment #12
jhodgdonD6 test bot is not working. The patch is fine...
Comment #14
gábor hojtsySuperb, thanks, committed.