Some file/image tests are failing

17:11:35.0.: menu_execute_active_handler --> call_user_func_array --> system_batch_page --> _batch_page --> _batch_do --> _batch_process --> call_user_func_array --> _simpletest_batch_operation --> DrupalTestCase::run --> FileFieldValidateTestCase::testFileExtension --> node_load
Array
(
    [0] => 
)

we're passing crap into node_load_multiple(), that's dump of $nids before this line in node_load():

  $node = node_load_multiple($nids, $conditions, $reset);

and that's because we don't validate FileFieldTestCase::uploadNodeFile() actually worked:

The specified file <em class="placeholder">image-test.png</em> could not be uploaded. Only files with the following extensions are allowed: <em class="placeholder">txt gif</em>.

looks like the code that calls FileFieldTestCase::updateFileField() was broken by the changes in this issue #693084: Regression: file_munge_filename() extension handling broken by move to File Field:

    // Disable extension checking.
    $this->updateFileField($field_name, $type_name, array('file_extensions' => ''));

that no longer does what it says in the comment. don't have time to figure out the magic incantation we need to pass in here now, will circle back to it later unless someone beats me to it.

This is much, much simpler than it looks. this commit:

http://drupal.org/cvs?commit=385780

changed the file sizes, so we no longer get a GIF image from:

     $test_file = $this->getTestFile('image');

so the tests that blindly expect that fail. attached patch changes the tests to use actual extension of $test_file. now the broken tests pass.

oh, seems there are more tests to fix, patch coming shortly.

now with a little bit less broken, upload tests pass, still have to fix:

Image field display tests (ImageFieldDisplayTestCase) [Image] 98 8 3
Image field validation tests (ImageFieldValidateTestCase) [Image] 24 2 3
Image styles path and URL functions (ImageStylesPathAndUrlUnitTest) [Image] 44 2 0

ok, the broken tests now pass for me locally.

how do we get the bot turned back on?

updates as per #16.

@Dries - the point of the indirection is to make the tests able to survive changes to the test files.

seems overly brittle to depend on exact file names, sizes and dimensions if we don't need to. we're testing stuff like 'can i add an extension to the list of extensions and upload a file with that extension' etc.

webchick suggested we could just put the hardcoding back, and i'm not totally opposed to that, but it seems better to me to avoid that unless we have to do it.