I enabled your module yesterday and the styles in admin/settings/wysiwyg_imageupload came in like so:

Spacing 20px Border=imgupl_styles_spacing_20_black_border\n\rBlack Border=imgupl_styles_black_border\n\rSpacing 5px=imgupl_styles_spacing_5\n\rSpacing 10px=imgupl_styles_spacing_10

And didnt work right.

It should have looked like:

Spacing 20px Border=imgupl_styles_spacing_20_black_border
Black Border=imgupl_styles_black_border
Spacing 5px=imgupl_styles_spacing_5
Spacing 10px=imgupl_styles_spacing_10

Also, the description help text for the styles in admin says:

...descriptive name to make it easier to handle. The syntax is "Descriptive Name=imgupl_style_XYC". You _must_ prefix the style with imgupl_style_*! For each style use on separate line.

It should say "imgupl_styles_XYC" AND "imgupl_styles_*!" Notice the "s". Should say styles (plural) not style (singular).

CommentFileSizeAuthor
#12 wysiwyg_imageupload_quotes.patch868 bytesn3ko
#3 imgstylesfix.patch884 bytesthat0n3guy

Comments

eugenmayer’s picture

eugenmayer commented
Status: Active » Closed (won't fix)

Well there is a migration issue with the styles, but i dont think its critical at all, as it actually can bi fixed with 10 seconds duty.

They second thing, actually is singular, as the style is one style. That pretty common.

I mark this as wontfix (migration error) as the effort to correctly migrate those styles is pretty huge. I will change the docs though, to be sure people are aware of this isse.

Thanks for the feedback

that0n3guy’s picture

that0n3guy commented

thanks

that0n3guy’s picture

that0n3guy commented
Status: Closed (won't fix) » Needs review
StatusFileSize
new imgstylesfix.patch884 bytes

Eugen,

This is a simple fix, I figured it out on accident :).

This patch is against http://github.com/EugenMayer/wysiwyg_imageupload#

eugenmayer’s picture

eugenmayer commented
Status: Needs review » Patch (to be ported)

Looks good :) Thank you for the patch!

that0n3guy’s picture

that0n3guy commented

No problem, could you commit it to github...

Thanks

eugenmayer’s picture

eugenmayer commented

I will :)

eugenmayer’s picture

eugenmayer commented
Status: Patch (to be ported) » Fixed

well thats not the solution for the problem, this will overwrite all styles, not migrating them. Anyway i wont put any work into this, as its extremly minot. That patch at lest keeps the module functional.

that0n3guy’s picture

that0n3guy commented

That just fixes it so it works on the first install.... no migration involved.

eugenmayer’s picture

eugenmayer commented
Status: Fixed » Closed (fixed)
alexbk66-’s picture

alexbk66- commented
Status: Closed (fixed) » Active

I reopened this issue as I still have a problem.

I didn't change anything, just installed the module. If I select 'Spacing 20px border' style, that's the html generated:

<span class='wysiwyg_imageupload image imgupl_floating_left imgupl_styles_spacing_20_black_border\n\rBlack Border'>
alexbk66-’s picture

alexbk66- commented
Status: Active » Closed (fixed)

[EDIT] Worked it out, closing again

n3ko’s picture

n3ko commented
Version: 6.x-2.0 » 6.x-2.9
Status: Closed (fixed) » Active
StatusFileSize
new wysiwyg_imageupload_quotes.patch868 bytes

I found this bug in a fresh install, and looked after in git too.
The quote bug still present.
Please apply the patch.
TY.

eugenmayer’s picture

eugenmayer commented
Status: Active » Patch (to be ported)

ah, that one is a goog catch n3ko! missed that double quotes.. will be included in the next 3.x release

eugenmayer’s picture

eugenmayer commented
Version: 6.x-2.9 » 6.x-3.0-rc2