The help text for the core-rsync command gives the wrong flag names for "--exclude-path" and "--include-path". They are currently listed as plurals ("--exclude-paths" and "--include-paths"), which effectively ignores the specified paths.

There is also a typo in the description for both flags, misspelling "comma" as "coma."

Here is the current help text (whitespace edited for readability):

 --exclude-paths       Coma-separated list of paths to exclude.                             
 --include-paths       Coma-separated list of paths to include.

and here is the patched text:

 --exclude-path       Comma-separated list of paths to exclude.                             
 --include-path       Comma-separated list of paths to include.

Patch attached.

Thanks,
Paul

CommentFileSizeAuthor
#1 rsync_paths.patch1.29 KBgravelpot

Comments

gravelpot’s picture

gravelpot commented
StatusFileSize
new rsync_paths.patch1.29 KB

Hm, sorry -- patch didn't get uploaded with that post.

gravelpot’s picture

gravelpot commented
Category: bug » task

Sorry again, still feeling my way through the issue submission process. I see this shouldn't be listed as a bug report.

moshe weitzman’s picture

moshe weitzman commented
Assigned: gravelpot » greg.1.anderson

Maybe we should go with the plural? I guess that could break a few people's code during upgrade. Lets let Greg decide.

greg.1.anderson’s picture

greg.1.anderson commented

I left the help text as-is, and changed the code to accept either the singular or the plural. It's only a very small amount of backwards-compatible code, and when moving scripts between different machines with drush, it would be disastrous if an include / exclude option was sometimes missed. Better to be safe, at least for now.

greg.1.anderson’s picture

greg.1.anderson commented
Status: Needs review » Fixed
greg.1.anderson’s picture

greg.1.anderson commented
Status: Fixed » Patch (to be ported)

Better put this in 3.x too.

anarcat’s picture

anarcat commented
Status: Patch (to be ported) » Fixed

We have discussed the policy of the drush 3.x branch at a BOF at Drupalcon CPH and it was agreed to only include critical and security fixes on the branch, to make it easier to sync in the official distributions (e.g. Debian). New features and small bug reports like this one, unless really critical or security, will therefore be refused for the 3.x branch.

greg.1.anderson’s picture

greg.1.anderson commented
Version: » All-versions-3.x-dev
Status: Fixed » Active

Maybe you should at least fix the documentation so that it matches the code, then...?

greg.1.anderson’s picture

greg.1.anderson commented
Status: Active » Fixed

Nevermind....

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.