There are a few places where syntax has to be modified to remove PHP5.3 warnings about passing a value instead of a reference.
With this done, however, the report is empty. What is happening is that the loop building $rows in theme_hacked_report() relies on $project['project_type'] which is always empty.
A naughty quick hack adding a constant value of "module", like
if (empty($project['project_type'])) {
$project['project_type'] = 'module';
}
enables the table to build and display the packages, but this is clearly incorrect and not sufficient: all packages are then flagged as "unchecked", including core, bringing no value over the normal update_status display.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 842056_php53_notices_hacked_3.patch | 416 bytes | fgm |
| #3 | 842056_php53_notices_hacked.patch | 431 bytes | greggles |
Comments
Comment #1
steven jones commentedFor 2.x, let's do it!
Comment #2
steven jones commentedProject type is used now, could you provide a patch against 6.x-2.x for any other 5.3 errors please?
Comment #3
gregglesI found one more place with a similar problem.
I'm not sure of any others.
Comment #4
fgmWouldn't it be shorter/better to just use empty() instead ?
Comment #5
steven jones commentedThanks, committed in: 6456e65e397a9b1c74069bd50c7485c8c79045f4