There are a few places where syntax has to be modified to remove PHP5.3 warnings about passing a value instead of a reference.

With this done, however, the report is empty. What is happening is that the loop building $rows in theme_hacked_report() relies on $project['project_type'] which is always empty.

A naughty quick hack adding a constant value of "module", like

if (empty($project['project_type'])) {
  $project['project_type'] = 'module';
}

enables the table to build and display the packages, but this is clearly incorrect and not sufficient: all packages are then flagged as "unchecked", including core, bringing no value over the normal update_status display.

Comments

steven jones’s picture

Title: No results on PHP5.3 » PHP5.3 compatibility
Version: 5.x-1.0-alpha6 » 6.x-2.x-dev
Category: bug » feature
Status: Active » Needs work

For 2.x, let's do it!

steven jones’s picture

Status: Needs work » Postponed (maintainer needs more info)

Project type is used now, could you provide a patch against 6.x-2.x for any other 5.3 errors please?

greggles’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new431 bytes

I found one more place with a similar problem.

I'm not sure of any others.

fgm’s picture

StatusFileSize
new416 bytes

Wouldn't it be shorter/better to just use empty() instead ?

steven jones’s picture

Status: Needs review » Fixed

Thanks, committed in: 6456e65e397a9b1c74069bd50c7485c8c79045f4

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.