Closed (fixed)
Project:
Webform
Version:
6.x-3.4
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Jul 2010 at 14:56 UTC
Updated:
13 Jan 2011 at 03:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
quicksketchA lot of "machine_keys" are lower case only, such as node types and field names. The design pattern in Drupal 7 for entering these things also assumes lowercase keys. However I think we could allow upper case characters if the user manually adjusted the key. In both D6 and D7 we prepopulate the key value with lowercase and underscores, so most people should be able to avoid accidentally using uppercase. A lot of users don't know that PHP is case sensitive and it leads to a lot of headaches when theming.
Comment #2
vernond commentedWould it not be more expedient to add a bit of strtoupper code in your mail.tpl?
Oops: Just noticed that you have lowercase mixed in there as well...
Comment #3
feuillet commentedThat would be nice. Maybe it would be more fool-proof if ther would be a checkbox like "allow upper case characters" or something underneath the custom key-form to toggle off the lowercase validation...
Comment #4
rhlowe commented+1 Subscribing
Comment #5
quicksketchI've committed this patch to the 3.x branches to allow uppercase characters in the component names. Fields are still converted to lowercase by default but it can be manually adjusted if necessary.