The Form generation page (http://api.drupal.org/api/group/form_api/7) contains a link ( Form API reference — http://api.drupal.org/api/drupal/developer--topics--forms_api_reference....) that takes to a page for Drupal 6.

CommentFileSizeAuthor
#6 drupal-form-generation-link-842998.patch821 bytestayzlor

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Active » Closed (works as designed)

I tried to fix this months ago and was overruled. The philosophy:
- When D7 becomes the current version, the link will be correct
- When D8 goes into development, we would have to change the link suffix to /8 to have the Form API page point to the right FAPI reference page.

So, tenatively setting this to "by design". Sigh.

Anonymous’s picture

Anonymous (not verified) commented

What will happen when Drupal 8 is marked as the current version? The link will take to the Drupal 8 page; the effect is then to not give a correct page now, and when Drupal 8 will be out.

Island Usurper’s picture

Island Usurper commented
Status: Closed (works as designed) » Active

OK, I'll disagree with the overruling.

Sure, when D7 becomes the current version, it will be correct. And when D8 becomes the current version, it will be wrong! It seems obvious to me that http://api.drupal.org/api/group/form_api/6 should point to D6 pages and http://api.drupal.org/api/group/form_api/7 should point to D7 pages. Whenever the D8 begins development, there ought to be some kind of checklist that reminds people to change things like this.

Anonymous’s picture

Anonymous (not verified) commented

Not only the link would be wrong for Drupal 8, but also for future versions of Drupal.
Considering that there are still users using Drupal 5 modules when Drupal 7 is almost at the doors, there could be still users using Drupal 7 when Drupal 9 will be ready. :-)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Title: Documentation problem with the Form generation page » Form generation page link needs updating
Version: 7.x-dev » 8.x-dev
Issue tags: +Novice, +Needs backport to D7

Actually, I think this is fixable. The link in the code should just be to the file name forms_api_reference.html rather than to the full URL. That should generate the correct URL for the correct version.

tayzlor’s picture

tayzlor commented
StatusFileSize
new drupal-form-generation-link-842998.patch821 bytes

Hey!,
Attaching patch for #5.

tayzlor’s picture

tayzlor commented
Status: Active » Needs review
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Closed (duplicate)

Sorry, somehow two issues for this got created. The other one is more complete (and is currently postponed):
#699604: Use file name rather than full URL for links to Form API Reference page