First and foremost, the Is Published checkbox doesn't seem to do enable or disable the discount.
Second, the term "Published" should be reserved for nodes. You don't really publish a discount. You should enable or activate a discount.

This patch fixes the functionality of activating a discount and changes wording as well as the database column to "is_active".

Comments

davidburns’s picture

StatusFileSize
new9.3 KB

fixed typo

ryangroe’s picture

The is_published field originally created to tell the codeless discount field to display or not. It wasn't named very well. I actually don't know if the codeless discount field uses that flag anymore, so I think your patch is a good idea. If the field is there it should actually do something :)

At some point I would like to restore the "display or not" flag for the codeless discount field. In case you do not use it that flag shows any codeless discount in the product page by striking the original price and putting the discounted price in red beneath it. I imagined that a site admin might not want to "publish" every codeless discount (even if the discount was applicable to the user). Though it appears that no one is missing this functionality in the codeless discount field so maybe no one needs it.

kevster’s picture

That does sound like good functionality to me - just confusing labelling as I though it meant whether the discount was active or not. Great module and much easier to use than other ones. Would be very useful to be able to activate or unactivate discounts?

Thanks, Kevin

ryangroe’s picture

Initially I thought to myself "I don't need an enabled/disabled flag because there is an expiration date". However there have been a couple of bugs around expiration and it overall is a bit confusing. So I think there needs to be an enabled flag for easier discount administration.

sam_gigo’s picture

#877498: Add the ability to set a discount as being active or inactive

Adds an is active checkbox without modifying is published

-------------------------------
http://www.dhmedia.com.au

davidburns’s picture

patch provided in #1 committed to dev branch
http://drupal.org/cvs?commit=404310

davidburns’s picture

Status: Active » Fixed

setting status to fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.