Hello,

I've added two features to this module that may be of interest to others.

  • Select the versions of IE that should be shown the message bar. So, for instance, one could show the bar to every user of IE 7 and lower.
  • Persistence. Should the message bar be shown to the user once? Or, as is the way currently, on every page load of your site.

I've really taken a liking to CSS3's border-radius and wanted to gently suggest (one time, then shut up) Firefox to an IE 8 or lower user so he/she might see the rounded corners. So, this module was almost there for me and the changes to ie6update.module in this patch are where I took it.

This is the first time I've contributed to a contrib module, so if I've made the patch incorrectly or something let me know.

I also suspect the persistence option will only work when caching mode: disabled or you're dealing with a logged-in-user. I'll do a little testing...

Thanks!

CommentFileSizeAuthor
Screenshot-31.png75.56 KBchrisolof
patched_ie6update_07-02-2010.patch3.97 KBchrisolof

Comments

bionitech’s picture

bionitech commented

I would find it extremely annoying to have this message pop up on every page. There should be a way to make it only pop up once per user, per session, or per IP. Could the use of Cookies aid in this respect?

batje’s picture

batje commented
Status: Patch (to be ported) » Reviewed & tested by the community

@bionitech this is exactly what this patch does.

I applied it, and its nice. Does what it has to do, and with ie7 support soon dropped by Google, this extends the lifetime of the module. And the way it implements the toolbar makes it the nicest ie module for me.

Would be nice if the patch could be committed to the ie6 branch.

iamEAP’s picture

iamEAP commented
Status: Reviewed & tested by the community » Needs work

The persistence feature doesn't work if page caching is enabled.

Marking as "needs work."

iamEAP’s picture

iamEAP commented
Title: Version and Persistence Features » Persistence Features
Version: 6.x-1.3 » 6.x-1.4

Renaming so that this only covers persistence; re-opening another ticket (#535046: IE 7 Configuration) related to IE versions.