Hello

first: THANKS for this theme, I love it.

Second, I have one really simple suggestion. I always change this when I work with it (which is always :D)

I wrap the header, main and footer into #-wrapper

I end up having this

...
      <div id="header-wrapper"><div id="header">
...
      <div id="header-wrapper"><div id="header">


      <div id="main-wrapper"><div id="main" class="clearfix">
...
      </div></div> <!-- /main-inner /main -->


        <div id="footer-wrapper"><div id="footer">
...
        </div></div> <!-- /footer /footer-wrapper -->
...

This allows me to use full width background for header and footer, which is always handy :D

Attaching the css and html with my change.

Also, there was an indentation error in page.tpl.php.
PAGE div content was not indentent properly.

Cheers

Federico

CommentFileSizeAuthor
#2 layout.css_.txt2.24 KBjm.federico
#2 page.tpl_.php_.txt5.25 KBjm.federico

Comments

jm.federico’s picture

jm.federico commented

right, so what I meant was

...
      <div id="header-wrapper"><div id="header">
...
      </div></div> <!-- /header /header-wrapper -->


      <div id="main-wrapper"><div id="main" class="clearfix">
...
      </div></div> <!-- /main-inner /main -->


        <div id="footer-wrapper"><div id="footer">
...
        </div></div> <!-- /footer /footer-wrapper -->
...
jm.federico’s picture

jm.federico commented
StatusFileSize
new page.tpl_.php_.txt5.25 KB
new layout.css_.txt2.24 KB

Files

SteveK’s picture

SteveK commented
Status: Active » Closed (won't fix)

I like to maintain proper hierarchical structure within the code to make it easy to insert and traverse through the DOM elements when using text editors such as Textmate (which make it easy to collapse and expand elements for hiding). Feel free to modify the code as you wish, but this one won't be making it in for the purpose of "short-hand".