Duplicate [node-url] token definition with token module

I (and others it appears) are still having this issue. Can this be addressed? I am not sure how to correctly modify the module, though Dave gives a hint at: http://drupal.org/node/834484.

Thanks,
Maria

Patch against current development version. May also apply to other versions as well.

Tried but it doesn't work for 6x2.2 This is a great module could a new updated version could be released with a tested fix?
Thanks

I can confirm this patch fails on 2.2 - a kick ass back-port patch from 4.x dev would be great.

The most extreme problem is nodes load blank pages due to the conflict and renders them useless - and not just a log entry. :)

Patch against 6.x-2.x attached.

Dave, remind me, if we ever meet - I must buy you beer.

I'll buy the next one!!!

Thanks.
Thanks to Dave this is not a disaster (since Token only generates watchdog warnings now), but it would be nice if it can be incorporated soon.

Together with a change on the module page: "Requirements: Token >= 6.x-1.14 / 5.x-1.15"

Attached patch for 6.x-4.x (replacing #2) removes a duplicate semicolon, though.

subscribe

subscribe

#5 patch works!

subscribe

I confirm. the patch #5 is working.

Me too #5 is good, THANKS Dave.

I recently upgraded my Token module, presumably(I've not looked) it introduced the 'node-url', thus bringing us into this duplicate scenario!

Does the "patch" fix the Duplicate node-url error message I get in log every time a user defined URL is clicked? This is since upgrade of main Drupal last week.
if so
How is the patch applied and which link do I download?

I'm a bit confused.

Will the Module be updated soon?

I can confirm that #5 solves the problem for 6.x-2.x - thanks!

@Mike - Search the Drupal documentation for "How to apply patches". This one is simple enough that you can just read the patch and manually apply the changes (delete two lines of code). Use the one on comment #5 if you have Notifications 6.x-2.x and #8 if you have 6.x-4.x

patch #5 works!

@ Dane Powell Thanks
In Cygwin, navigate to the module's directory for your Drupal install
??
From http://drupal.org/node/620014

What?

I had the pain years ago of installing cygwin to test some linux C on my NT4.0 Windows X windows. In recent years any Linux C work I have done on Debian, Barak and Ubuntu Linux distro

I had presumed I can either use Notepad ++ or Textpad to edit the PHP (which I've done on Wordpress and vBulletin and custom projects in the past) or some sort of autopatch tool.

This sort of makes more sense
http://drupal.org/node/534548

However I currently don't have a Test site. Only the real one. But I do have backups of the files and the SQL database.

So given that I can restore the file and it's not a big patch I can do it manually in a text editor?

I just comment out or delete?

- $tokens['node']['node-url'] = t('The node view url for read more links.');
- $values['node-url'] = url('node/'. $node->nid, array('absolute' => TRUE));


I can't see anything that needs added?

OK great folks

I just had to remember to re-enable the permissions on content Notifications etc! No error messages about [node-url]
I did manual comment out of the two lines with the patch name in post #5
I saved original version 1st.
Finding the lines in Notepad++ easy.

We don't get many new users a week, I always subscribe to new users till I see what they up to.

Adding better title to help others find this issue.

Thanks, patch worked. Subscribe.

# 5 works! Yay! Thanks

Subscribing

Any chance this will make it into a build for those of use to lazy, stupid, or fearful of screwing up a patch? :)

thanks #5

subscribe

thanks #5
This was blocking cron

tested, works, please commit

subscribe

Subscribe

Subscribing.

Subscribing. I think this is related to this issue as well - http://drupal.org/node/935614#comment-3548406

will the patch in#5 be comitted?

subscribe. having all my sites with this issue. thanks

#8 solved problem so far in 6.x-4.0-beta7.
Subscribing...

#5 works of course. Subscribing.

subscribing

subscribe.

subscribe

subscribe

subscribe

subscribe

Based on #946086: Read more links in email notifications we needed the patch from Dave in #5.

Would be great to have this committed. If I could mark RTBC again I would.

Indeed, this also causes a problem with tokens on localize.drupal.org. See #946520: Error in nofifications from localize.drupal.org - "Read more at Array".

Committed. Thanks.

I'll put out a stable release ASAP for 2.x branch

(Any of drupal.org sites running with the 4.x branch?)

I don't think any are running 4.x yet. I do hope to move g.d.o to that in the next few months (it's better, right?)

@greggles,

Though there are many improvements in 4.x, the current stable (2.x) is much better tested so maybe wait for now unless you need some new feature. It also needs to sync up again with latest OG. Atm we are working on the Drupal 7 branch instead.

Btw, I've just published a new (6.x.2.x) release.

Thanks.

@Jose Reyero or others,
Do you recommend dropping down to the 2.x version if we are currently running 6.x-4.x-dev ? What kind of problems would you anticipate with reverting back? Or should I just wait on new releases of 4x?

I have the 6.x-4.0-beta7 and still have this issue
Using the latest Tokens 6.x-1.x-dev (2010-Dec-14)

I can confirm that the Patch #2 is NOT fully implemented in the beta7 release.
There are basically 3 parts in the patch, only one is in place in Beta7
When I hand patched the other two, the error went away

Part-1 - NOT IMPLEMENTED in Beta7
-    $tokens['node']['node-content']    = t('The fully rendered node content.');
-    $tokens['node']['node-url']      = t('The node view url for read more links.');
+    $tokens['node']['node-content']    = t('The fully rendered node content.');;

Part-2 - Implemented in beta7
-  if ($type == 'comment' || $type == 'all') {  
+  if ($type == 'comment' || $type == 'all') {
     $tokens['comment']['comment-url'] = t('The comment view url.');
     $tokens['comment']['comment-reply-url'] = t('The comment reply url.');
   }

Part-3 - NOT IMPLEMENTED in Beta7
-        $values['node-url'] = url('node/'. $node->nid, array('absolute' => TRUE));

Not sure why Beta7 only has part of the patch but it dfoes?

So in Beta7 in the notifications_content.module these two changes made the Duplicate Tokens go away:

Comment out these two lines (to make a complete patch):
- $tokens['node']['node-url'] = t('The node view url for read more links.');
- $values['node-url'] = url('node/'. $node->nid, array('absolute' => TRUE));

Allan

I also had this problem on 6.x-4.x-beta7 and after removing the two lines mentioned by Allan in #52 it now works correctly.

Well, then I repeat my suggestion to split off the whole token stuff into a separate small module, esp. since the 'node-content' token is one big hairy ball of hairiness. And because non-notifications modules want these tokens too.

See #736328: render the node more completely for [node-body] to better handle cck fields (and others)
Say the word and I'll start trying to get others to cooperate on this small module.

I also had this problem with 6.x-4.x-beta7 after updating token.module. The solution in #52 seems to fix it.

subscribe. Using 4.x beta7

It is fixed in the -dev version.

The patch in #5 worked great - thanks.

Unfortunately, it only worked until Cron ran. When cron runs, the error in the logs does not return, but the node content that had not been showing (as also noted in #4), disappears once again. After running update.php, the content appears again. Obviously, I'd rather not have to run update.php after every cron job, so does anyone have an idea or can point me in the right direction for a fix?

I apologize, I had a problem with my panels layout. Again, the patch in #5 worked perfectly. Thanks.

in my drupal 6.22 site, in the ../admin/reports/status, there is below "Duplicate tokens" warning:

The following tokens are defined by multiple modules and may cause problems when performing token replacement.
* node:node-url (defined by modules: token, notifications_content)

the modules using are notifications-6.x-4.0-beta7.tar.gz and token-6.x-1.16.tar.gz. is there any patch available for resolving this issue? how to install the patch under Ubuntu environment?

Subscribing. Same error as #60. Same modules. Same versions.

Same as #60 which patch should I use? Is it fixed in the dev?

Thanks for module!

Here's a patch that works against 4.0-beta7.

Patch in #63 removed the "Duplicate tokens" warning in admin/reports/status with Notifications 6.x-4.0-beta7.
Thanks

#63 did the trick for me, although I had to apply it manually. I think the line numbers are offset. Basically just the two lines to delete. Thanks e.zeedub!

I also applied the patch manually because of a server without "git" and "patch" commands. I didn't tried to apply the real patch in #63.
Sorry for the confusion.

63 worked for me as well.

This is fixed in the -dev version, so this issue should remain at status 'fixed'.

As of today, there are not many changes in the -dev version (2011-Feb-26). Except the translation directories are gone, which is a good thing. Unless anyone did custom hacks, they can safely install this dev version.

I can confirm this bug exists in the latest current 6.x-4.x release, which is still 6.x-4.0-beta7 from 2010-08-01. Drupal's status report includes:

Duplicate tokens: The following tokens are defined by multiple modules and may cause problems when performing token replacement.

    node:node-url (defined by modules: token, notifications_content)

This bug prevents notifying the URL where the update happened, which is the main purpose of this module. Thus I have increased the Priority of this issue to critical.

However, the bug has already been fixed with committ http://drupalcode.org/project/notifications.git/commit/d33c4954892522658f9c25992e25b816582d24f8 on 2010-10-20, so updating 6.x-4.0-beta7 to the latest 6.x-4.x-dev will solve it.

We stumbled into this one too, given the age of the current dev release, seems like it's time for another beta?

@Ken Hawkins: agreed - maybe posting at #1571342: Notifications 6.x-4.0 release? may help getting a 4.x release sooner rather than later. Though would love to have #1772178: Provide a token that resolves into the recipient's RealName integrated first.