Closed (fixed)
Project:
Drupal core
Version:
x.y.z
Component:
node.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
16 Sep 2006 at 21:58 UTC
Updated:
6 Nov 2006 at 21:00 UTC
Leftover from the new FAPI migration
| Comment | File | Size | Author |
|---|---|---|---|
| node.module_44.patch | 851 bytes | yched |
Comments
Comment #1
drummPlease don't mark issues as ready to commit unless a second person has provided a positive review.
THis is a duplicate of http://drupal.org/node/75395.
Comment #2
yched commentedI'm sorry but I don't think this is a duplicate.
The way I understand it, http://drupal.org/node/75395 aims at enhancing node access management - bring na_arbitrator functionnality into core.
My (much much tinier) patch aims at fixing a (much much simpler) bug in the current state of 5.0, independantly of any hypothetical functionnal additions.
Steps to reproduce :
- go to admin/settings/node-access (you got to have at least two records in {node_access} table for the menu path to be defined)
- instead of the expected text + button allowing you to "rebuild the node_access table", all you get is the text "Array"
It's simply because the callback function has been ported to the new FAPi model (it returns a form array) while the menu definition has not been updated accordingly (does not set 'drupal_get_form' as its callback). I probably should have explained things a little more.
The patch is quite straightforward, and I would have said not really arguable - more like a typo. This is why I directly RTBC'd it, which I've seen done before on other 'typo-like' occasions, and which I of course don't usually do :-)
Patch still applies, BTW
Comment #3
yched commentedOK, http://drupal.org/node/75395 finally got in and corrected this as a side effect
Comment #4
(not verified) commented