Leftover from the new FAPI migration

CommentFileSizeAuthor
node.module_44.patch851 bytesyched

Comments

drumm’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

Please don't mark issues as ready to commit unless a second person has provided a positive review.

THis is a duplicate of http://drupal.org/node/75395.

yched’s picture

Status: Closed (duplicate) » Needs review

I'm sorry but I don't think this is a duplicate.

The way I understand it, http://drupal.org/node/75395 aims at enhancing node access management - bring na_arbitrator functionnality into core.

My (much much tinier) patch aims at fixing a (much much simpler) bug in the current state of 5.0, independantly of any hypothetical functionnal additions.

Steps to reproduce :
- go to admin/settings/node-access (you got to have at least two records in {node_access} table for the menu path to be defined)
- instead of the expected text + button allowing you to "rebuild the node_access table", all you get is the text "Array"

It's simply because the callback function has been ported to the new FAPi model (it returns a form array) while the menu definition has not been updated accordingly (does not set 'drupal_get_form' as its callback). I probably should have explained things a little more.

The patch is quite straightforward, and I would have said not really arguable - more like a typo. This is why I directly RTBC'd it, which I've seen done before on other 'typo-like' occasions, and which I of course don't usually do :-)

Patch still applies, BTW

yched’s picture

Status: Needs review » Fixed

OK, http://drupal.org/node/75395 finally got in and corrected this as a side effect

Anonymous’s picture

Status: Fixed » Closed (fixed)