Raw data series don't work [#845670]

Comment	File	Size	Author
#1	flot_raw_values.patch	1.78 KB	kyle_mathews
	flot_raw_values.patch	883 bytes	kyle_mathews

Comment #1

kyle_mathews commented 8 July 2010 at 17:42

Status	File	Size
new	flot_raw_values.patch	1.78 KB

New patch with much better handling of data. It now averages each raw_data value which falls within a given time period.

Log in or register to post comments

Comment #2

kyle_mathews commented 9 July 2010 at 04:36

Just noticed this issue is a duplicate of #663350: Fix support for 'raw' display option in the datapoint handler's pre_render() method

My patch has quite different behavior from the other issue. My patch averages all the raw values that fall in a group whereas Will's just adds them together. Both are valid for different use cases. Perhaps this distinction should be exposed in the UI?

Log in or register to post comments

Comment #3

kyle_mathews commented 9 July 2010 at 04:35

Perhaps people should be able to select the behavior they want, sum, mean, median, mode.

Log in or register to post comments

Comment #4

kyle_mathews commented 9 July 2010 at 04:37

Status:

Active

» Needs review

Log in or register to post comments

Comment #5

deggertsen commented 20 July 2010 at 19:27

Yes, I think before this is committed there should be options for people to select the behavior they want. However the patch above appears to work for averaging all of the raw values in the given period.

Thanks.

Log in or register to post comments

Comment #6

R.J. Steinert commented 22 July 2010 at 03:04

I think this idea of granularity could be dropped all together when dealing with raw data. At first I figured there was a data point being generated for every tick on the y axis because Flot.js requires it but that's not what I found when playing around with this example http://people.iola.dk/olau/flot/examples/time.html

I cut out a bunch of data in the middle and got the attached graph. It seems if we just feed Flot.js the actual raw data it would handle it just fine. I suppose if what we are trying to do is protect the end user from having to download a large dataset then removing data points could be useful but doing so seems like an additional feature as opposed to getting raw data to actually work. I try this out tonight or tomorrow unless anyone else knows better.

Log in or register to post comments

Comment #7

kyle_mathews commented 22 July 2010 at 18:16

Title:

Raw data series doesn't work

» Raw data series don't work

grammer check

Log in or register to post comments

Comment #8

R.J. Steinert commented 11 November 2010 at 22:50

I've hacked this module over here https://github.com/rj-steinert/Drupal-Flot

I commented out a lot of code and prepared the timestamps for output to be understood by javascript. This approach depends on Flot's own graphing logic to prepare the graph for display. I would love to have time to merge my work into the current module but it will require adding a lot more options for my different approach. I might just opt for making the Views support a new module.