Closed (fixed)
Project:
Bartik
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
5 Jul 2010 at 19:40 UTC
Updated:
20 Jul 2010 at 02:20 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #1
bleen commentedon it
Comment #2
bleen commentedblaarg ... this actually only happens when the .tabs are immediately followed by a fieldset with a legend (because legends use a negative top margin). We have two choices ... we can:
a) add some extra margin below .tabs ... this will fix the problem here but leave more space in every other scenario
b) use some ridiculously convoluted selector to get at this one situation
c) completely overhaul fieldsets and legends but I think this would be bad bad bad
the attached patch follows choice (a):
http://skitch.com/bleen/dmg6h/appearance-d7
http://skitch.com/bleen/dmg9g/content-d7
screenshots show with fieldset & without...
Comment #3
jensimmons commentedBecause I hate to click to see screenshots:
Comment #4
bleen commentedThis is a much better solution ... this solution offsets the negative margin used by legends so that ultimately the fieldsets end up in the correct location within the document.
That means that nothing will have weird spacing if its immediately above or below a fieldset, including the secondary tags...
http://skitch.com/bleen/dm8yf/appearance-d7
Comment #5
jensimmons commentedAgain, embedding the image with my documentation input filter superpower.
Comment #6
jensimmons commentedCommitted.