As seen on: admin/content/comment

bartik-comments-admin-squishy.png

Comments

bleen’s picture

Assigned: Unassigned » bleen

on it

bleen’s picture

Status: Active » Needs review
StatusFileSize
new509 bytes

blaarg ... this actually only happens when the .tabs are immediately followed by a fieldset with a legend (because legends use a negative top margin). We have two choices ... we can:

a) add some extra margin below .tabs ... this will fix the problem here but leave more space in every other scenario

b) use some ridiculously convoluted selector to get at this one situation

.tabs + .region-content .content > form > div > fieldset {
  top: 10px;
}

c) completely overhaul fieldsets and legends but I think this would be bad bad bad

the attached patch follows choice (a):
http://skitch.com/bleen/dmg6h/appearance-d7
http://skitch.com/bleen/dmg9g/content-d7

screenshots show with fieldset & without...

jensimmons’s picture

Because I hate to click to see screenshots:

Only local images are allowed.

Only local images are allowed.

bleen’s picture

StatusFileSize
new657 bytes

This is a much better solution ... this solution offsets the negative margin used by legends so that ultimately the fieldsets end up in the correct location within the document.

That means that nothing will have weird spacing if its immediately above or below a fieldset, including the secondary tags...

http://skitch.com/bleen/dm8yf/appearance-d7

jensimmons’s picture

Again, embedding the image with my documentation input filter superpower.

Only local images are allowed.

jensimmons’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.