This patch moves the feature setting (point, path, ...) to widget settings to provide more flexibility for additional widgets.
For example the OpenLayers Geocoder doesn't need a selected feature. I wrote a very small patch for the Geocoder widget to remove the requirement of this. That was the main reason for this patch.

Comments

zzolo’s picture

Status: Needs review » Needs work

Hi @Sanjo, thanks for the patch. I think this is good, there is no reason to have this setting on the field level as it does not actually affect how the data is stored. But, this needs to address the upgrade process as this will affect everyone using this field currently.

Sanjo’s picture

Status: Needs work » Needs review
StatusFileSize
new4.65 KB

Here it is. New hook_update_N() that transfers the openlayers_cck_feature_types from the global to the widget settings.

strk’s picture

Status: Needs review » Needs work

+1, that configuration should in in widget.
I'd also love to see an additional configuration in it to be stricter on data type, or at least limit number of geometries allowed
(see http://drupal.org/node/826788 for background)

CCK itself is currently not even validating, and always wants a GEOMETRYCOLLECTION so not much to configure in there
for the moment.

Sanjo’s picture

Status: Needs work » Needs review
StatusFileSize
new4.59 KB

Removed the debug messages from patch =)

zzolo’s picture

Hi @Sanjo, thanks for the new patch and sorry for delay. Sight review of patch looks good, but this will definitely require a little testing. Hopefully this weekend I can take a look at it.

Status: Needs review » Needs work

The last submitted patch, openlayers-cck-move-feature-settings-to-widget-845888-4.patch, failed testing.

zzolo’s picture

Status: Needs work » Needs review

Sorry @Sanjo, I totally dropped the ball on this one. I don't have much time for D6 work at the moment. Is anyone available to test this out, it looks good when I read it?

zzolo’s picture

Issue tags: -feature
zzolo’s picture

Issue tags: +feature
zzolo’s picture

Component: OpenLayers CCK » OL API

I am not sure why the test bot is failing on this. But, I'll need someone else to test this out before I can commit it. Thanks. Sorry for the lack of support on D6.

steinmb’s picture

Assigned: Sanjo » steinmb
Issue tags: -feature
StatusFileSize
new4.39 KB

The patch no longer apply. Re-rolling with a small fix to hook_update_N(), let's see if bot like this. Have not done a lot of testing but the changes makes sense.

pol’s picture

Status: Needs review » Needs work
ken-g’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)