Closed (outdated)
Project:
Openlayers
Version:
6.x-2.x-dev
Component:
OL API
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
6 Jul 2010 at 00:12 UTC
Updated:
25 Nov 2021 at 00:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
zzolo commentedHi @Sanjo, thanks for the patch. I think this is good, there is no reason to have this setting on the field level as it does not actually affect how the data is stored. But, this needs to address the upgrade process as this will affect everyone using this field currently.
Comment #2
Sanjo commentedHere it is. New hook_update_N() that transfers the openlayers_cck_feature_types from the global to the widget settings.
Comment #3
strk commented+1, that configuration should in in widget.
I'd also love to see an additional configuration in it to be stricter on data type, or at least limit number of geometries allowed
(see http://drupal.org/node/826788 for background)
CCK itself is currently not even validating, and always wants a GEOMETRYCOLLECTION so not much to configure in there
for the moment.
Comment #4
Sanjo commentedRemoved the debug messages from patch =)
Comment #5
zzolo commentedHi @Sanjo, thanks for the new patch and sorry for delay. Sight review of patch looks good, but this will definitely require a little testing. Hopefully this weekend I can take a look at it.
Comment #7
zzolo commentedSorry @Sanjo, I totally dropped the ball on this one. I don't have much time for D6 work at the moment. Is anyone available to test this out, it looks good when I read it?
Comment #8
zzolo commented#2: openlayers-cck-move-feature-settings-to-widget-845888-2.patch queued for re-testing.
Comment #9
zzolo commented#4: openlayers-cck-move-feature-settings-to-widget-845888-4.patch queued for re-testing.
Comment #10
zzolo commentedI am not sure why the test bot is failing on this. But, I'll need someone else to test this out before I can commit it. Thanks. Sorry for the lack of support on D6.
Comment #11
steinmb commentedThe patch no longer apply. Re-rolling with a small fix to hook_update_N(), let's see if bot like this. Have not done a lot of testing but the changes makes sense.
Comment #12
polComment #13
ken-g commented