Add .gz, .zip, and .sql as valid file extensions [#846434]

The module enables fine and no complains, but when I try and upload a *mysql.gz file using the restore feature Drupals file verification code seems to kick in and tells me it is not an allowed file extension.

This happens with Drupal 7 dev from July 4 and the current dev snapshot of Backup and Migrate.

Comment	File	Size	Author
#5	backup_migrate-846434-5.patch	917 bytes	JeremyFrench
#4	backup_migrate-846434-4.patch	912 bytes	tim.plunkett
#2	backup_migrate.module.patch	955 bytes	VladRM

Comments

Comment #1

tsvenson commented 10 July 2010 at 18:42

Priority:

Normal

» Critical

Now tried with alpha 6 with the same error:

The specified file [archive name].mysql_.gz  could not be uploaded. Only files with the following extensions are allowed: jpg jpeg gif png txt doc xls pdf ppt pps odt ods odp.

Also got this log message:

Location  http://nut/sites/all/modules/backup_migrate/backup_migrate.js?l5cu9j
Referrer  http://nut/admin/structure/backup_migrate
Message  sites/all/modules/backup_migrate/backup_migrate.js
Severity  warning

Comment #2

VladRM commented 26 August 2010 at 08:13

Status	File	Size
new	backup_migrate.module.patch	955 bytes

I confirm the issue.

We have backup_migrate.module @line 618:

function backup_migrate_ui_manual_restore_form_submit($form, &$form_state) {
  if ($file = file_save_upload('backup_migrate_restore_upload')) {
    backup_migrate_include('destinations');
    backup_migrate_perform_restore('upload', $file->uri, $form_state['values']);
  }
  $form_state['redirect'] = BACKUP_MIGRATE_MENU_PATH . '/restore';
}

I added a validator for file_save_upload:

function backup_migrate_ui_manual_restore_form_submit($form, &$form_state) {
  $validators = array(
    'file_validate_extensions' => array('gz zip sql'),
  );
  if ($file = file_save_upload('backup_migrate_restore_upload', $validators)) {
    backup_migrate_include('destinations');
    backup_migrate_perform_restore('upload', $file->uri, $form_state['values']);
  }
  $form_state['redirect'] = BACKUP_MIGRATE_MENU_PATH . '/restore';
}

The file extensions passed to the validator may be insufficient, please review.