I swore I posted this somewhere on the Drupal forums but I can't find it now.

I tried using banner 4.6 on a 4.7 site and it didn't work. Someone suggested using the cvs version....I said I would try it and now have and got the same errors.

Any ideas?

Comments

wulff’s picture

Status: Active » Closed (fixed)

Banner.module has been branched for 4.7. It will be available on the download page next time the packaging script is run. Please try it out and report any issues you run into.

mdowsett’s picture

Status: Closed (fixed) » Active

will do. is there another module for 4.7 that does similar functions? Just looking for a way to present ads and track views and click thru's

wulff’s picture

Judging from the commerce/advertising category on drupal.org (http://drupal.org/project/Modules/category/55), the banner module is the only solution integrated with Drupal. The other modules are for displaying ads from external ad systems (adsense and textlinkads) AFAICT.

mdowsett’s picture

is see the banner.module just got updated yesterday for 4.7 sites....maybe the owner was watching my comments.

I haven't had a chance to try it but will report what I find.

mdowsett’s picture

Version: 4.6.x-1.x-dev » 4.7.x-1.x-dev

installed it....it's not working. I get new errors when I try to enable the banner blocks:

warning: Illegal offset type in /home/httpd/vhosts/dowsett.ca/subdomains/gravsports/httpdocs/modules/taxonomy.module on line 890.
warning: Illegal offset type in /home/httpd/vhosts/dowsett.ca/subdomains/gravsports/httpdocs/modules/taxonomy.module on line 900.
warning: Illegal offset type in /home/httpd/vhosts/dowsett.ca/subdomains/gravsports/httpdocs/modules/taxonomy.module on line 901.

I disable the banner module and it goes away...

Any ideas?

wulff’s picture

I have just committed a potential fix for this (banner module v1.70.2.4).

The module was using an incorrect default value for the vocabulary variable.

mdowsett’s picture

no go I am afraid. I still get the same errors on the admin>blocks page ( as listed above).

I also get this error when I go to the admin>banners page (but I hoping that one will be resolved once the above error gets fixed???).

thx for tryign to fix this. It is rather key to my site.

mdowsett’s picture

I forgot to paste the error on the admin/banner page

user warning: Table 'gravsports.banner' doesn't exist query: SELECT COUNT(*) FROM node n INNER JOIN banner b ON n.vid=b.vid INNER JOIN users u ON n.uid=u.uid in /home/httpd/vhosts/dowsett.ca/subdomains/gravsports/httpdocs/includes/database.mysql.inc on line 120.
user warning: Table 'gravsports.banner' doesn't exist query: SELECT n.*, b.*, u.name FROM node n INNER JOIN banner b ON n.vid=b.vid INNER JOIN users u ON n.uid=u.uid ORDER BY workflow ASC LIMIT 0, 25 in /home/httpd/vhosts/dowsett.ca/subdomains/gravsports/httpdocs/includes/database.mysql.inc on line 120.

wulff’s picture

To reinstall the module you have to run the following query after disabling the module:

DELETE FROM system WHERE name='banner'

Otherwise, the banner table won't be created when you enable the module.

chase_elliott’s picture

I'm having trouble re-installing the Banner module. I dropped the banner table from the database using the query, but when I go to the modules page to enable the new version of banner I get:

user warning: Table 'drupal.banner' doesn't exist query: SELECT tn2.tid FROM node n INNER JOIN term_node tn ON n.nid = tn.nid INNER JOIN term_node tn2 ON n.nid = tn2.nid INNER JOIN banner b ON n.vid = b.vid WHERE tn.tid = 17 AND b.workflow = 1 in /var/www/html/wmgt/includes/database.mysql.inc on line 120.

My problem was that anonymous users weren't able to view banners. Other roles could.

Thanks much.

Bèr Kessels’s picture

There are a lot of issues with the 4.7 version. We should split this out:
* Mysql misses a column (location) (or else pg should not have this)
* the vocabulary stuff is severely broken when deploying on a live site. Errors all over the place, banners not working, no longer able to add /any/ vocabulary to the site!

And some minor issues.

I strongly suggest you remove the 4.7 branch for now, it is in a bad state right now.

sun’s picture

Status: Active » Fixed

Current version of banner module for 4.7 is working (at least with PgSQL).

Although you might need to delete database tables banner and banner_terms from a prior installation and execute the above query in #9.

If you want upgrade functionality for Banner module, then please open a new issue for that.

Anonymous’s picture

Status: Fixed » Closed (fixed)