Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I just stumbled into this when trying to set up the forums in the CVS version of Drupal 7 & editing it admin/structure/forum
I could see an alphabetize list, but not the drag/drop.
I think this is because of the use of depth rather than weight, but I'm not sure. I didn't realize that drag/drop was being used in the forums as well.
Comment | File | Size | Author |
---|---|---|---|
#21 | 846524-taxonomy-term-overview-ax-2.patch | 5.65 KB | AaronBauman |
#16 | 846524-taxonomy-term-overview-ax-2.patch | 3.46 KB | mgifford |
#14 | 846524-taxonomy-term-overview-ax.patch | 4.79 KB | AaronBauman |
#14 | taxonomy_term_overview_form.png | 197.23 KB | AaronBauman |
#8 | screen-capture-19.png | 57.45 KB | mgifford |
Comments
Comment #1
mgiffordOh ya, this is related to #448292: Drag and Drop for table rows is not accessible to screen-reader users
Comment #2
mgiffordComment #3
bowersox CreditAttribution: bowersox commentedWhat is the root cause of the problem here? Does anyone know how Forum is using weight (or can you explain how "depth" is used instead)?
Also, is it broken for all users or only for users doing "Re-order rows by numerical weight instead of dragging"?
Comment #4
mgiffordIt's just broken if you've clicked on the Show/Hide weight link we brought into the Drag/Drop. It's enabled & working fine if you either click on it to zip back to normal or just haven't clicked that link before.
I'm not sure why it is inconsistent.
Comment #5
Everett Zufelt CreditAttribution: Everett Zufelt commentedI don't seem to understand the problem.
What is this UI supposed to do?
What is it doing currently?
Comment #6
mgiffordIn the screen capture in #1 that I didn't describe, sorry, I didn't see any weight tables available when the drag/drop interface was disabled. All I saw was a title row & the edit row.
Are you able to to reorder the forums? Maybe there's another issue that was interfering with my ability to see the weight.
Comment #7
Everett Zufelt CreditAttribution: Everett Zufelt commentedWhat happens when you load this page with JS disabled?
Comment #8
mgiffordPretty much the same thing. I get inputs for edit-tid70-tid & edit-tid70-depth but not for weight. Code is here:
Sceenshot of the top of the table (without Javascript enabled) is attached.
Comment #9
Everett Zufelt CreditAttribution: Everett Zufelt commentedSetting to critical as this table cannot be reordered using the weight column. It is 'possible' that this could be resolved if the correct inputs are set to text and not hidden.
Comment #10
Everett Zufelt CreditAttribution: Everett Zufelt commentedComment #11
AaronBaumanForum uses the default taxonomy form, which displays the same symptoms described here.
This issue is a duplicate of #448292: Drag and Drop for table rows is not accessible to screen-reader users
Comment #12
AaronBaumanAfter slogging through the comments, looks like this ticket was spawned from 448292, so should probably stand on its own.
Renaming to reflect greater scope of the issue.
There's also a disconnect between the label "Show row weights" and the fact that a vocabulary hierarchy is defined by depth (parent tid) in addition to weight.
Comment #13
mgiffordIn that very long Drag/Drop thread we did deal with the depth issue by stating that it needs to be managed by editing the item. There was no way of gracefully displaying the options of parents. However the weight column was something that could be managed in a table format like this.
The weight column just doesn't appear to be displayed within the taxonomy module.
Comment #14
AaronBaumanHere's a first stab at this issue:
It might be unwieldy for 100+ term vocabs, or vocabularies with non-unique term names, but it's better than having to edit each term one at a time.
There are certainly improvements to be made, but this at least makes the taxonomy term overview form accessible.
Screenshot demonstrates this patch with a devel-generated taxonomy after enabling "Show row weights".
Comment #16
mgiffordWe'd discussed adding the depth in the broader drag/drop discussion & at that time decided not to include a parent drop/down for other forms.
I've removed this from your patch & uploaded another version. Perhaps it will get by the bots this time.
Thanks for doing this.
Comment #17
mgiffordgo bot go
Comment #19
AaronBauman#16: 846524-taxonomy-term-overview-ax-2.patch queued for re-testing.
Comment #21
AaronBaumanupdated tests
Comment #22
mgiffordThanks! This looks good to me.... Now who should look at it to see that it's RTBC?
Comment #23
grey_beard CreditAttribution: grey_beard commentedApplied patch & tested; it works!
Comment #24
marcingy CreditAttribution: marcingy commented#21: 846524-taxonomy-term-overview-ax-2.patch queued for re-testing.
Comment #25
webchickAwesome, thanks.
Before this patch, although the "show row weights" link appears, it doesn't actually do anything. This patch puts back in the behaviour so it matches with similar drag-and-drop screens (menu, etc.)
Committed to HEAD.
It would be really great if someone could document the "best practice" around how to create an accessible tabledrag table in source code form as part of the Examples for Developers project. In Drupal 8, we should look at building such accessibility into the element automatically.