The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.I noticed that geoip_language.txt file is used in files/ but when I add a new language, it's not reset therefore no changes are visible until I delete it manually. Is that intentional?
To be honest, I feel that this feature is not needed. It's a lot of hassle for just one SQL query. I would cache that statically in one page load and use Drupal cache system for it. It wouldn't be any problem for small sites and bigger ones are using memcache anyway.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | geoip_language.patch | 857 bytes | Zardoc |
| #6 | geoip_language.patch | 2.21 KB | Zardoc |
| #5 | geoip_language.patch | 2.19 KB | Zardoc |
| #3 | geoip_language.patch | 1.82 KB | Zardoc |
Comments
Comment #1
drewish commentedI kind of agree with you. I think the initial intent of it was to allow the redirection to occur before Drupal was fully bootstrapped. See the geoip_language.fastpath.inc for an example.
That said adding a language shouldn't alter the file until you provide a country mapping, right?
Comment #2
drewish commentedComment #3
Zardoc commentedThis patch fixes the issue until a better workflow can be implemented.
Comment #4
drewish commentedindenting seems off, also it'd be good to have that file generation code moved into a helper function.
Comment #5
Zardoc commentedUpdate of geoip_language.patch.
Comment #6
Zardoc commentedgeoip_language.patch final.
Comment #7
Zardoc commentedHere is a better fix for this issue. Using this method we flush the static cache as well as update the geoip_language.txt in the file system.
Comment #8
drewish commentedThanks, committed to HEAD.