PHP errors I found, linked to webform block

They are not really errors but a php notice usually suggests the code could be improved. I also got annoyed with these notices appearing in my logs so slightly changed the code.

Here is the altered function for 6.x-1.1 if you compare to the original you will see the slight differences. Nothing major just checking array keys actually exist before trying to use them. Hope that helps.

function webformblock_form_alter(&$form, $form_state, $form_id) {

  if ($form_id == 'webform_node_form') {
  
    $form['webform']['advanced']['addblock'] = array(
      '#type' => 'checkbox',
      '#return_value' => 1,
      '#default_value' => webformblock_nodestatus($form['nid']['#value']),
      '#title' => t('Generate a block'),
      '#description' => t('Allow this form to appear in its own block which can be positioned in any block region.'),
      '#weight' => -20,
    );
  } elseif (isset($form['#parameters'][2]) && $form['#parameters'][2]->webform['addblock'] == 1) {
    $node = $form['#parameters'][2];
    form_clean_id(null, true);
    $anchorname = form_clean_id(str_replace('/', '', strtolower( drupal_get_path_alias('node/' . $node->nid) ))); 
    $form['#action'] = url(drupal_get_path_alias($_GET['q']), array('fragment' => $anchorname)); 
  }
}

also has a small whitespace fix

Looks good to me

My solution of the problem for Webform Block 6.x-1.2:

Sorry, the file was lost. Here it is:

This worked for me to get rid of the errors.

Rerolled against latest stable for makefile usage.

That patch had 2 whitespace errors and still produced PHP warnings. Here's a new one (still rolled against 6.x-1.2 stable - does not apply to head).