It would be nice to have a Delete option beside each row, similar to the Edit link.
Also it would be nice to have them as graphics, since the text takes more space. Similar to the Report Criteria page graphics.

CommentFileSizeAuthor
#3 847610.patch1.28 KBjimbullington

Comments

jimbullington’s picture

The delete option should not be a problem. I'm not sure about the icons, however. Maybe we could add a formatting option for icons instead of text for these columns.

todd zebert’s picture

subscribe

jimbullington’s picture

StatusFileSize
new1.28 KB

A patch for the 'Delete' option is attached.

jimbullington’s picture

Status: Active » Needs review
vako’s picture

Thank you Jim. I see that you've been busy lately doing new improvements on the module.
When will these patches be applied to the actual module code? at least at the Dev level?

jimbullington’s picture

Once I get some initial feedback on the patches I will commit to CVS. I'll then put together one more final beta, and if all goes well, a stable release shortly after that. Shouldn't take but a few more weeks - depending on the feedback.

todd zebert’s picture

I'm willing to test this patch in my dev environment, but I'm using Beta5 now - will it work?

jimbullington’s picture

Yes, the patch is for BETA5. Thanks!

todd zebert’s picture

Jim,

I questioned the versioning because this issue is marked beta4.

Anyway, I applied the patch manually since it was only 4 lines.

I tried a number of deletes/adds, viewing the webform submissions/table, and also the Reports - no issues.

A nice to have would be a way (a link?) to return the user to the WFR after edit or delete!

Thanks!

jimbullington’s picture

Version: 6.x-2.0-beta4 » 6.x-2.0-beta5
Status: Needs review » Reviewed & tested by the community

Since the delete/edit is handled by the webform module, I cannot return to the WFR. Thanks for testing!

vako’s picture

Tested and it works great! thank you very much Jim!

vako’s picture

Just suggestions to improve the module features:

- On the Delete confirmation screen, would it be possible to display which record is being deleted.
- On the main report, Check Boxes on each row so we can select more than one row to delete.
- Replace the Edit and Delete options with graphics, similar to the ones in the Report Criteria section. That way the text will not be part of the entries, will not take as much space and will look nicer...;)

Of course after a Delete or Edit it would be nice to go back to the report screen, but I see in post #10 that it's not that easy to implement. Suggestion: would it be possible to save the report URL in a variable and then redirect to that URL or put a link so we can click on it?

Thanks a lot for this fantastic module!!

jimbullington’s picture

Status: Reviewed & tested by the community » Closed (fixed)