Allow other forms to be called through colorbox [#847840]

Add hook_colorbox_form_access($form_id);

Allow other modules to use colorbox, passing in the form id

Example:
/**
* Implementation of hook_colorbox_form_access().
*/
function my_module_colorbox_form_access($form_id) {
$access = FALSE;
if ($form_id == 'forward_form') {
return user_access('access forward');
}
return $access;
}

Comment	File	Size	Author
#3	colorbox_hook_form_access_847840.patch	2.29 KB	frjo
	colorbox_hook_access.patch	1.95 KB	aufumy

Comments

Comment #1

frjo commented 20 August 2010 at 05:30

This looks neat!

Just some minor stuff.

Could we not simply skip the following part?:

    if ($access) {
      return $access;
    }

And what you think about wrapping the module_implements part like this:

  // hook_colorbox_form_access
  if (!$access) {
    foreach (module_implements('colorbox_form_access') as $module) {
      $access = module_invoke($module, 'colorbox_form_access', $form_id);
    }
  }

No need to run the hook if access is already true?

Comment #2

aufumy commented 8 July 2010 at 16:54

The if (!$access) , is a good idea. Alternatively, there could be returns inside the case statement.

Regarding removing the if ($access) within the foreach, if there are two modules A and B with hook_colorbox_form_access, then by default both will return false, unless A allows $form_id to go through.

However, without the if ($access) inside the foreach, hook for $form_id will be overwritten.