I've seen this bug reported all over the place on Drupal, and mostly it seems to be connected to the use of the $language variable. Not sure if that is the problem here (the code clearly uses this variable), but I get this error only when viewing a user profile, and it goes when switching the module off, so it must be the cause.

Comments

danielb’s picture

danielb commented
Category: bug » support
Status: Active » Closed (fixed)

You have not sufficiently identified a bug, or given me information to reproduce the error. If you are convinced this module is doing something wrong, please describe the problem in the code, or supply a patch.

jpcwebb’s picture

jpcwebb commented
Component: Code » User interface

I'm not a developer, so I'm not producing patches - have changed the component item accordingly. I'm not sure how else to explain this. I also noticed that the button on the profile page where the error occurs shows 'Send on time login link to Object', whereas I presume Object should actually be the username, so I am assuming the part of code that is referencing the username is conflicting with something in common.inc

jpcwebb’s picture

jpcwebb commented
Status: Closed (fixed) » Active
jpcwebb’s picture

jpcwebb commented
Status: Active » Needs review

Think I've found the problem, and I suspect (though can't be certain) that it is a conflict with the Realname module. On line 168, the function login_one_time_button is passed a refernce to $account rather than the username, so changing this from

'#value' => login_one_time_button($account, NULL, $select),

to

'#value' => login_one_time_button($account->name, NULL, $select),

seems to fix the problem.

jpcwebb’s picture

jpcwebb commented

Ah no, that didn't work - although it got rid of the error and allowed the button to render the username correctly, the button itself doesn't work (500 error - seems to be unable to find the email address to send to) :(
So I guess login_one_time_button needs an actual reference to the user account, not just the name - but then it causes the original problem which seems to be centred around the use of $username on line 215 in function login_one_time_button_form. So I think somewhere in the logic for login_one_time_button the test for the $username as an object is failing and being passed onto the form instead of the name value, maybe because it has been affected by Realname (at a guess - from what I understand it dynamically replaces references to the name property of $user and $account objects). More thought needed...

danielb’s picture

danielb commented
Category: support » bug
Status: Needs review » Active

Thank you, I now see the problem is in the function login_one_time_button()
This code:
if (is_object($username) && isset($account->name)) {
should be this
if (is_object($username) && isset($username->name)) {

danielb’s picture

danielb commented
Status: Active » Fixed

I have committed the fix to CVS and created a new release (RC2) for this module.

danielb’s picture

danielb commented

By the way the fix you tried should have worked, and I have also made that change in the new version in addition to fixing the bug, so you may be experiencing a second problem. If it continues to be unable to find the email address you might need to start a 2nd issue for that (that way i can track changes properly in the CVS log). PS now you are a developer.

jpcwebb’s picture

jpcwebb commented

Hi again,
Yes, I spotted that line of code too and changed it, also fixing the button display, but not the actual functioning of it. For the time being I have disabled the button on the profile page and just relying on the bulk action use instead, but I will start a new issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.