Problem in drupal_write_record [#848228]

I think there's a bug here - the details field returned from paypal is an array but gets written to the db as text. This fixes it:


/**
 * Handles an incoming PayPal IPN.
 */
function simple_payments_paypal_ipn() {
	$ipn = $_POST;
	if(!_simple_payments_paypal_ipn_verify($ipn))
		return;

	if($ipn['payment_status'] != 'Completed')
	  return;


  $payment = simple_payments_explode_custom($ipn['custom']);

  $payment['gateway'] = 'paypal';
	$payment['currency'] = $ipn['mc_currency'];
	$payment['amount'] = bcmul($ipn['mc_gross'], 100);
  $payment['timestamp'] = strtotime($ipn['payment_date']);
	$payment['details'] = $ipn;
	

	simple_payments_payment_received($payment);
}

Comment	File	Size	Author
#6	simple_payments-848228-5.patch	1.16 KB	osopolar
#4	simple_payments-848228-4.patch	1.15 KB	osopolar
#3	simple_payments-848228-3.patch	691 bytes	osopolar

Comments

Comment #1

miiimooo

Europe

commented 8 July 2010 at 11:03

Oops.. that was the wrong piece of code. Here we go again:

/**
 * Handles a payment recieved from a payment gateway.
 *
 * @param $payment
 *   The payment that has been received.
 */
function simple_payments_payment_received($payment) {
  
  $payment['details'] = serialize($payment['details']);
  drupal_write_record('simple_payment', $payment);

  _simple_payments_payment_log($payment);
	simple_payments_payment_process($payment);
}

The details field is marked as serialized in simple_payments.install so drupal_write_record() takes care of serializing it itself. There should be no need to do this in simple_payments_payment_received(). Do you get an error regarding an unserialized details field?

Comment #3

osopolar

German

🇩🇪 GER 🌐

commented 17 July 2010 at 03:26

Status	File	Size
new	simple_payments-848228-3.patch	691 bytes

The details field is marked as serialized in simple_payments.install. This is a typo and needs to be serialize (without the d), see: http://api.drupal.org/api/group/schemaapi.

Patch attached.