Making the module more programming friendly

Nice one Ye! Will include.

Patch applied. Released ast 6.x-1.2

Is it just me, or did the 6.x-1.2 release not properly remove line 57?

52 function workflow_create_state_for_stateless_nodes($state_name = NULL) {
53   // Get workflow state id either from function argument or last argument of URL.
54   // Then look up the id associated with the name.
55   $state_name = $state_name ? $state_name : end(arg());
56 
57   $state_name = end(arg());

The patch file shows line 57 completely removed. As it stands, because it hasn't been removed, $state_name will never take the argument value.

Please correct me if i'm wrong.

Thanks,
HenryLTV

I've sorted this out. Here's my post that attempts to sort all of this out:
http://drupal.org/node/681932#comment-3575278

Line 57 should be removed. Reclassing as a bug report, as the module does not do what it advertises on the front page.

As noted, the 1.2 patch did not allow for programmatic access to the module code due to a bug on line 57. This patch addresses that issues and a whole lot more.

I've refactored the code quite a bit, moved all hard-coded URLs to constants (for easier changes as needed by end-users), re-worked the API function for consistency, and eliminated all UI calls (like drupal_set_message) from within the API function.

I've also reworked the URLs to utilize the ?destination= parameter in the calling URL if suppled, modified the URL structure handlers to better detect issues with passed URLs, as well as fixed a lot of the feedback messaging to be more helpful.

The attached patch should be applied to an UNMODIFIED 1.2 release. Applying other code fixes first will cause this patch to break.

Hope this helps someone!

That's great achbed!
Can you please also attach the result source. With all the changes you made it's probably easiest to just past that over the top and check it in.
Cheers!
Rik

Happy to! See attached.

oh, and for reference, this is the list of changes I put in my copy of the readmechangelog

6.x-1.3
=======
Added URL redirect after processing (supports destination parameter in URL if given)
Split URL processing and API function into two separate functions
Moved URL references to constants
Better handling of URL errors/input problems
Altered error and status messaging for clarity
Added separate published/unpublished node handling