I think there should be a global setting in the module's options that would let the admin limit the phone countries available in the drop-down menu when creating a cck field. I was thinking perhaps a list of checkboxes? This would enhance the usability of the menu greatly. Imagine that this list is not complete and it will get larger and larger as new countries are supported.
As an added bonus, the site's enabled languages could be auto-detected and then have the corresponding phone countries' checkboxes enabled as defaults in this list. I mean, it is only natural for sites to want to handle phone numbers of countries depending on the site's available languages (with the exception of the generic 'International Phone Numbers per E.123', which I think should be enabled anyways).
Thanx in advance for considering this one.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | phone-settings.patch | 5.95 KB | bleen |
| #5 | phone-settings.patch | 16.09 KB | bleen |
| #4 | phone-settings.patch | 5.92 KB | bleen |
Comments
Comment #1
stoob commentedExcellent point. I am not using this module simply because it makes the creation of new content types so annoying with all the menu options. We only need 3 countries in the list, there should be a way to reflect that. Uninstalled.
Comment #2
klonos...missed that 'r' in the 'count(r)ies' ;)
I honestly had started worried... ~6.000 people using this module and not a single one had the same issue(?).
Comment #3
wackadoodle commentedsubscribe - concur with OP
Comment #4
bleen commentedwow .. this has been making me nuts. So I fixed it :) patch attached. I didn't get so fancy with the auto-detecting, but this patch will allow you to choose the available phone formats.
Comment #5
bleen commentedkeepin up with the latest version (this includes some white space and coding standard fixes too ... thats why the patch is so large
Comment #6
bleen commented... and here it is without the whitespace changes so it can actually be sanely reviewed
Comment #7
klonosI haven't used the module for a while. I'll see if I can test this though.
Comment #8
eric constantinides commentedSO NEEDED!!! Great job!
Comment #9
bleen commented#8, is that a review of the patch in #6? or just an affirmation that this problem needs to be solved?