Line 464 of imagemenu.module adds 'style=float: left' to reorganise menu items from a vertical list to a horizontal list. There are two problems with this approach. First, using float takes the content out of the normal content flow (http://www.w3.org/TR/CSS2/visuren.html#floats) which makes it difficult to do things such as, say, centring the menu items to a page. More importantly, though, because the float is hardcoded into the raw HTML, it's impossible to override it with a CSS file because the style property will always take precedence!

I see two possible solutions to fixing this problem. The first is to make a 'horizontal-imagemenu' or something-to-that-effect class so that the property is CSS selectable and have the mod provide its own mutable CSS file. The other, quicker and dirtier approach, is to change 'style=float: left' to 'style=display: line' on line 464 which will avoid the problems with using floats and will, at least for the time being, make me happier :)

CommentFileSizeAuthor
#3 imagemenu.module.diff1.65 KBAnonymous (not verified)

Comments

glennnz’s picture

glennnz commented

+1

Quick fix above works, but need to be style=display: inline, not style=display: line

Anonymous’s picture

Anonymous (not verified) commented

Much obliged. Thanks for catching my typo.

Anonymous’s picture

Anonymous (not verified) commented
Assigned: Unassigned »
Status: Active » Needs review
StatusFileSize
new imagemenu.module.diff1.65 KB

I decided to roll up my sleeves and take a stab at fixing the problem myself. Please find attached a patch file for imagemenu.module (somewhat but not exhaustively tested). In addition to this patch,

.imagemenu-horizontal {
  display: inline;
}

needs to be added to imagemenu.css.

This is my first patch ever so please forgive me if my use of diff is riddled with errors.

Fanaile’s picture

Fanaile commented

I applied this patch and have done some preliminary testing on one site.

So far I have not come across any problems and the menu is working nicely. I will let you know whether or not any errors come up or if I come across any issues.

summit’s picture

summit commented

Subscribing, greetings, Martijn

ratinakage’s picture

ratinakage commented

Was this patch ever applied?

Anonymous’s picture

Anonymous (not verified) commented
Version: 6.x-1.2 » 6.x-1.x-dev
Assigned: » Unassigned
Priority: Minor » Normal

Nope! Still present as of version 1.4. Surely someone can take 10 minutes to merge the patch in. Of course, with other changes, it'll probably need reworking!

summit’s picture

summit commented
Status: Needs review » Reviewed & tested by the community

Shouldn't this be RTBC then?
greetings, Martijn

Anonymous’s picture

Anonymous (not verified) commented

The project may need new maintainers since neither have logged in during the past year

Anonymous’s picture

Anonymous (not verified) commented
Title: There must be a better way to code Horizontal Layout » Patch to get Horizontal Layout working correctly
Issue summary: View changes
pobster’s picture

pobster commented

It's not abandoned, I just didn't imagine that anyone would still be using D6. Also this module was originally written for D4.7 (I think, it was quite a long time ago) and there are far better ways to achieve image menus now. Creating a separate menu system to hold this information is just not necessary anymore, all that's needed is to alter the menu forms to add the upload box. Anyways, with modern-thinking I very much doubt anyone should be making menus like this anyway? That said, I see there's a whole bunch of modules that have sprung up which offer the same functionality.

Pobster

pobster’s picture

pobster commented
Status: Reviewed & tested by the community » Closed (outdated)

Closing as D6.x is now unsupported.