Hey Berdir and everyone,
I've been testing the D7 version and noticed that adding the "[user]" suffix to specify the user (rather than the role with the same name) doesn't seem to work. I'm getting a message that the user isn't valid.
Basically, if you have a user named "editor" as well as a role named "editor," you can't specify "editor [user]" to send a message to the user (and not the role).
This functionality exists in the D6 version, but doesn't seem to work yet in D7....
--Ben
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | fix_direct_user_addressing.patch | 1.79 KB | berdir |
Comments
Comment #1
berdirPretty obvious when you think about it. name [user] is not a valid user name, so we need to remove [user] before checking if it is a valid username.
Comment #2
BenK commentedThanks! I tested this with several different combinations and everything works great, just as expected. So I think this is ready to be committed! :-)
--Ben
Comment #3
BenK commentedThanks! I tested this with several different combinations and everything works great, just as expected. So I think this is ready to be committed! :-)
--Ben
Comment #4
berdirCommited to 7.x-1.x.
Comment #5
soulfroysI have the newest 6.x-2.x-dev version and a editor role too... "editor, editor [user]" doesn't work. Did I miss something?
Comment #6
berdirYes, you are. This simply has not been ported to 6.x-2.x, it has only been commited to 7.x-1.x. This will most certainly be ported in the next few days, probably tomorrow.
Comment #7
berdirPorted and commited.