Forum topics locked after migrating comments [#850784]

Hi,

After running the node convert tool, I get the following effects:

- All the forum topics are marked as "Topic Locked"
- If edit a topic in the forum as admin, it's marked as Read/Write (!?!? - So why topic locked?). If you change it to "Read only", the action is ignored (continues to be Read/Write)
- If you add a new topic to the forum, the page shown is a previous topic to add a comment.

I rolled back the DB three times, converting them again, and got the same result.

Any idea here of what's going on would be really appreciated.

Thanks.

Comments

Comment #1

crea commented 11 July 2010 at 08:55

>>If you add a new topic to the forum, the page shown is a previous topic to add a comment.
This bug is fixed in dev version

>>If edit a topic in the forum as admin, it's marked as Read/Write (!?!? - So why topic locked?). If you change it to "Read only", the action is ignored (continues to be Read/Write)

This bug is being dealt with in #848598: Nodecomments doesn't track changes to the node comment setting. Can you test this patch together with dev release of Node Comments ?

Comment #2

juan.bangkok commented 12 July 2010 at 04:01

Thanks for your reply crea.

Using the dev version with the patch fixes the "new topic" problem: now it's possible to create new posts.

The problem with read only comments has changed: now you can select read only / read-write in the topic and it saves it. The advanced forum module still marks it as "Topic locked" though.

Do you think this can be considered an advancedforum bug?

Comment #3

crea commented 12 July 2010 at 08:33

I'm not sure if Advanced Forum is smart about that: AF was using Node Comments for a long time but this is first time reported here. For any node with nodecomments set up Node Comments module disables comment status on node_load() and saves it inside $node->nodecomment (so that core comments don't apply). So any module willing to know *real* comment status would need to check that instead of $node->comment (unless the module accesses DB stored value directly).
I think we can't call it a bug. It's incompatibility issue.

Comment #4

crea commented 12 July 2010 at 16:35

Status:

Active

» Closed (works as designed)

I'm marking this "by design" because the whole thing of disabling $node->comment while saving it in $node->nodecomment was decision of previous module developers to make the module compatible with the core "comment" module. It causes many problems but I think it's too late to change this behavior inside 2.x branch. For 3.x branch (if there will be one) it makes sense to completely isolate Node Comments comment setting from the core's one. It will cause some problems too (because modules will still need to be aware of Node Comment setting) but overall it will be much cleaner approach.

Comment #5

sivi commented 11 August 2010 at 23:19

I'm using nodecomment-6.x-2.0-beta6.tar.gz with advanced_forum-6.x-1.1.tar.gz, og_forum-6.x-2.2.tar.gz, og-6.x-2.1.tar.gz. I have deleted all comments and all topics. It's supposed to be clean start. When I create new topic, it emerges with "Locked" status. Before nodecomments everything worked smoothly. Yet it is essential requirement to have unlimited attachments of various kinds in comments, as it serves as exchange board.

"Locked" buttons appear at the top and the bottom. Nevertheless, "reply" button reserved to the intial entry and "reply" links which are bound to comments themselves are functional.

Any advice how to heal the problem?

Thanks in advance.

15 min later: advanced_forum-6.x-2.0-alpha3.tar.gz does not show this problem with lock.