Update options checkbox doesn't include labels

If you click on the main 'Content' link in the toolbar you go to admin/content which provides you with a list of all recent content (that you can filter). You can also publish/unpublish/delete/etc content in mass by checking on the checkbox in the first column of the table on that page.

None of these checkboxes has a label associated with them. This patch adds a label.

There was a MySQL failure & no mysql so I'm going to assume that the bot was having trouble & retest this.

update_option_labels-1.patch queued for re-testing.

Trying this thanks to @Heine

forgot to change status.

#6: update_option_labels-2.patch queued for re-testing.

For accessibility you want to set the title attribute, ensure that there is a label but you need to hide the label from the browser.

That's why the line for:

$title_display = 'invisible';

is there. There are no visual changes caused by the patch. It's completely different for screen readers, but folks not using assistive technology will never notice that it is there.

Just apply the patch yourself and see if you notice any changes.

yes, this is true. However, try it and look at the html.

Forms API does need to be re-written for D8 and hopefully it will include this at that time. However adding a title, like this:
http://api.drupal.org/api/drupal/developer--topics--forms_api_reference....

isn't very clean.

You could add an #attributes tag & insert the title there I suppose.

However, I'm really not sure what your concern is with the existing approach. It might fail a lot less & require less rewriting of tests I suppose..

The label isn't visible if the patch I provided is applied. It's a very simple patch.

When you tested your code did you see tooltips over the form elements? I don't think I've seen this before. I'm still not sure why you think it's a better approach.

The critical problem I find with your patch though is that you haven't added the title data using:

$title = t('Select update options for @row', array('@row' => $element['#options'][$key]['title']['data']['#title']));

'Select this row' doesn't add value.

This is a trivial change. There are going to be lots of them around. However, it's been sitting here since July 11th & I'd actually forgotten about it. Ended up reposting the issue & patch here:

#882672: Label missing in Update options

I'll mark that one as a duplicate, but let's get these simple accessibility labeling issues into core quickly.

@casey, title attributes do not add to accessibility in modern screen readers most of the time. It will not be displayed to the screen.

Woops.. @casey, guess I was wrong there in this context.

@everett - so the patch in #15 above works well for you?

So for all of these instances where I've been proposing labels you'd be happier if we were using title attributes instead for the form?

It's not a big change in code.

The initial vision of the implementation was that we'd have the attribute tag to associate with a title element so that we could just have the title included like it is for form_pre_render_conditional_form_element():

     $element['#attributes']['title'] = $element['#title'];

However there was some problem with this, so it only ever got brought into the pre render function for checkboxes and radios.

I can't recall the specifics but we weren't able to generalize it. I think that's going to have to wait till D8 to get properly implemented. (BTW - Where, when, how do we begin discussing the re-framing of FAPI for D8?)

I've set the title manually here http://drupal.org/node/882694#comment-3334358

It looks more hacky to me in the code. It also is giving a warning with tools like WebAIM's WAVE because it is less well understood than the label. Might act the same, but it isn't treated the same in the community. Most discussion is geared towards labels & forms not labels/titles & forms.

Updating to keep up with core. Reverting to using labels as it's the established pattern & will help with eventual migration to D8.

I'm really at a loss as to how this test fails with the comment module.

#23: update_option_labels-3.patch queued for re-testing.

Seems totally absurd that this patch throws 73 fail(s), and 1 exception(es) in Simpltest.

That's a lot of code to meddle with. Need a Simpletest guru to fix this up quick!