Thank you so much for this important addition to UC

Whenever Show List Position is disabled (hidden) for a content type, and Price fields are enabled (shown), the Price fields are not visible.

When Show List Position is enabled (shown), and Price fields are enabled (shown), then the Price fields are visble (as expected).

CommentFileSizeAuthor
#1 20100715_show_nested_field.patch1.4 KBpieterdc

Comments

pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented
Status: Active » Needs review
StatusFileSize
new 20100715_show_nested_field.patch1.4 KB

I got the same issue.
It's a little more general than you described.
The fieldset gets hidden if all "root level" fields are hidden.
And as the price fields are nested within...

Hence the code that works with $hide_product_info_fieldset

I created a patch, see attached, to fix this.
Does it fix your problem too, Colorado?

willvincent’s picture

willvincent commented

Something tells me (having not had time to actually look at the code yet) that this issue is related to the recent request to hide "empty" fieldsets. I had a feeling that wasn't the best feature to include.

colorado’s picture

colorado commented

PieterDC -

Thank you so much!

I tried your patch, and it seems to work...

pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented

@tcindie
It is related to the code that was introduced by this feature request: #771162: Hide Product Information fieldset if all its content is hidden

pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented
Status: Needs review » Reviewed & tested by the community

as of Colorado's comment, we can change the status to 'reviewed'

keereel’s picture

keereel
Primary language Russian
commented

+1, subscribe.

echoz’s picture

echoz commented

Ah ha! This is what my problem is in #846202: price field missing on create/edit form I've marked it as a duplicate. Does the patch in #1 properly get rid of the "hide empty fieldsets" patch?

pieterdc’s picture

pieterdc
Primary language Dutch
Location Ghent
commented

It doesn't get rid of the "hide empty fieldsets" patch.
It "only" gets rid of the unwanted side-effect of hiding fields we don't want to hide.
But if all fields are hidden, it will still hide the fieldset.

willvincent’s picture

willvincent commented
Status: Reviewed & tested by the community » Closed (fixed)

Included in version 6.x-1.12