Repeatable: Always
Steps to repeat:
1. Enable Domain Settings
2. Visit an administrative page with domain specific settings. (eg. admin/settings/site-information)
3. Save the settings selecting a specific domain.
4. Revisit this page.
Expected Results:
Is selected the correct option, that for which the settings are saved in the "Domain-specific settings"
Actual Results:
Is selected the option according with "Domain settings behavior" (in admin/build/domain/settings > Domain-specific settings).
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | domain-remember_selection_for_domain_settings_form-851460-5.patch | 2.88 KB | osteron |
Comments
Comment #1
agentrickardThis is by design. It would be burdensome to store the form option for every single configuration form. If you want different behavior, this is a feature request that needs a patch.
Comment #2
xjm#898548: Set domain-specific settings radio button default contextually is a duplicate.
I think it would be possible to make the radio button "smart" without having to actually store its state, since we have already loaded domain-specific settings into the form. Just a matter of detecting whether or not domain-specific settings were loaded and getting that info into
domain_settings_form_alter().Edit: Hm. It seems kind of magic to me atm. How do the domain-specific settings get loaded into the form?
Comment #3
agentrickardThe form settings themselves are loaded based on the active domain -- see the logic in domain_conf.module. The Domain Settings module just lets you select which domain to save the current settings to.
Really, this isn't a simple task. The form is already smart if you select 'active domain' as the default behavior.
The module is, after all, optional, and designed to replace hook_domainbatch() in most cases. So if it causes workflow problems, I would move the forms you need to update into that hook.
Comment #4
agentrickardChanging title to reflect the request, since this is by design and not a bug.
Comment #5
osteron commentedThis patch adds a new settings behavior for the domain settings form. 'Use the default domain (except overridden)'
It is like the normal 'Use the default domain' except that when you made changes in the current form it selects the current domain.
It gets all the current domain specific settings and compares them with the form elements. If there is a match the domain is selected.
One issue is that you can still only unset the settings to the default when you choose 'All domains'.
Comment #6
agentrickardI am very hesitant to change behavior this late in the release cycle.
Comment #7
bluegeek9 commentedDrupal 7 in End of Life and no longer supported. We encourage you to upgrade to a supported version of Drupal. For more information, see https://www.drupal.org/upgrade.