By ashsc on

I know about CCK but that's not what I'm using. Instead I've created a module to define a custom content type following the instructions found here:

http://drupal.org/node/231019

and referencing the node_example.module found here:

http://api.drupal.org/api/drupal/developer--examples--node_example--node...

My module creates a new content type that adds my own custom fields to those of a base node. My custom fields are related in a way that begs for a table layout.

I would like to theme the basic table structure in the module code (ie. not in any .tpl files). I thought I needed the following methods (note that I have more than these in my module, but I though these were the ones related to theming):

1. hook_form() for defining my node's form.

function my_module_form(&$node) {
  // define array of form fields in $form here and then...

  return $form;
}

2. hook_theme() for declaring a theme function for the theme engine to use for my new form.

function my_module_theme() {
  // declare theme function
  return array(
    'my_module_form' => array(
      'arguments' => array('form' => NULL),
    ),
  );
}

3. theme_[item]() for theming the form.

function theme_my_module_form($form) {
  // generate $header and $rows arrays from form fields here and then...

  return theme('table', $header, $rows) . drupal_render($form);
}

...but it seems I'm wrong.

What is the proper way to customize the html of my custom node fields?

⋅ Categories: Drupal 6.x

Comments

nevets’s picture

nevets commented

Are you trying to customize the input (form) or node output?

And what seems wrong about that approach?

ashsc’s picture

ashsc commented

Yes, the node input form. Sorry I didn't state that and thank you for showing interest in my post.

Well, my theme function isn't doing anything with my form elements. I've cleared the cache and reloaded the form with no success.

I assumed either node forms in particular don't allow that method of form theming or I've made a minor error somewhere. I noticed on this page http://api.drupal.org/api/function/hook_nodeapi/6 that perhaps I should be using hook_nodeapi() in conjunction with hook_form_alter().

Modules use hook_form_alter() to place additional form elements onto the node edit form, and hook_nodeapi() is used to read and write those values to and from the database.

So should I be using hook_form() to establish my basic node type, hook_form_alter() to add my elements and then hook_nodeapi() with its "prepare" $op to theme? As in:

1. hook_form()

function my_module_form(&$node) {
  // configure node $form title and body fields here and then...

  return $form;
}

2. hook_form_alter()

function my_module_form_alter(&$form, &$form_state, $form_id) {
  switch ($form_id) {
    case 'my_module':
      // add my new $form elements here, no need to return $form as it is passed by reference...
      break;
  }
}

3. hook_nodeapi()

function my_module_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
  switch ($op) {
    case 'prepare':
      if ($node->type == 'my_module') {
        // theme my form elements in $node, no need to return as $node is passed by reference...
      }
      break;
  }
}
jaypan’s picture

jaypan
Location Victoria, BC
commented

If it's the node input form, you can do something like this:

function hook_form($node)
{
  $form['stuff']['#theme'] = 'my_theme';
  $form['stuff']['my_first_element'] = array(
  // element definition
  };
  return $form;
}

function hook_theme()
{
  return array
  (
    'my_theme' => array
    (
      'arguments' => array
      (
        'form' => NULL,
      ),
    ),
  );
}

function theme_my_theme($form)
{
  $output = t('This my form element:') . drupal_render($form['my_first_element']);
  return $output . drupal_render($form);
}

Hopefully this can point you in the right direction.

Contact me to contract me for D7 -> D10/11 migrations.

ashsc’s picture

ashsc commented

Thank you so much. This is what I was looking for and it absolutely works for what I'm trying to do.

I'll add a note that the placement of the '#theme' element in the $form array seems to be important. I'm assuming the theme engine will only allow me to theme sub-elements of the $form array and not the entire $form array. Putting every element in a $form['wrapper'] sub-element might change that. In either case:

I had luck with:

$form['my_item']['#theme'];

but not with:

$form['#theme'];
jaypan’s picture

jaypan
Location Victoria, BC
commented

You can use $form['#theme']. Though maybe not for node forms now that I think of it.

Contact me to contract me for D7 -> D10/11 migrations.