I'd prefer to have this module display one block instead of two. Rather than having a separate block for taxonomy links, they should be included in the Related Links block under the subheading "Related Terms".

CommentFileSizeAuthor
relatedlinks.module.patch_5.txt9.66 KBcolan

Comments

Zen’s picture

Zen commented
Status: Needs review » Fixed

Applied a slightly modified version of this patch; IIRC, the only change of consequence that I made was to move the variable check from _relatedlinks_get_terms to the hook block. Please review when you get a chance :)

I am also of the opinion that the structure should be as follows:

  • If (as in your original patch) the header (title) for a particular link type are specified in the related links settings page, then that set of link types should reside in a separate block. Or perhaps, this can be accomplished better with a checkbox.
  • If the header is left empty, then the list of links should be appended to the list before it (seamlessly).
  • To have two or three lists with their own headers in the same block is IMO pointless.. if a user wants such a layout, he should do it by messing with his CSS.
  • I have however left this section as is for the time being as it will hopefully be addressed with your second patch.

As mentioned earlier, this has been committed to HEAD, not the 4.7 branch. Please check accordingly.

Cheers :)
-K

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

I agree that sublists without headers should join the previous list. That makes total sense.

As for having separate blocks for each link type, I'm not convinced that it's a good idea. I think it looks much more organized to have all links in one block and then sub-classify them. What about if we add a checkbox to the link type configuration? Is that what you meant? If enabled, that link type will be in its own block (unless there's no header). If left unchecked, there would be a section for that link type in the related links block.

This "Separate Block" control would leave the decision up to the user, without him/her having to mess around with the CSS.

Zen’s picture

Zen commented

Distinct sub-divisions within the same block go against the very nature of a block and immediately ties down the administrator's options. Separate blocks provides the admin with a lot more flexibility and manageability and allows him/her to leverage other modules such as block bar etc.

Cheers,
-K

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
commented

Ah, I see what you mean now. Okay, I'll address this with the configuration patch.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)