similar to #703888 (http://drupal.org/node/703888)

Under some circumstances the ids of the organization, project and task are empty in the function stormticket_list_filter(), because the form is not submittted to stormticket_list_filter_filter(). When the options of the select are not equal with the $form_state value the validation fails in the form.inc. This patch sets the ids from $form_state if the session is emtpy.

CommentFileSizeAuthor
stormticket.admin_.stormticket_list_filter.patch1.09 KBcarsten müller

Comments

juliangb’s picture

juliangb commented

The patch looks logical. If someone could test, this can be RTBC.

Needs retesting before commit in case things have changed. #684016: Fix E_NOTICE notifications will change a fair few files.

juliangb’s picture

juliangb commented

Would it be possible to clarify how I test this please? (What bug am I expecting to see before patch?)

carsten müller’s picture

carsten müller commented

hmm, long time ago. I don't know now the problem appeared. The result is the error message from the form validation "An illegal choice has been detected". I know it happend under some circumstances, but fool as i am, i did not write the way to reproduce the bug.

juliangb’s picture

juliangb commented
Status: Needs review » Postponed (maintainer needs more info)

Leaving this as needs more info - as although the patch looks like a logical sort of thing to add, we need to know why we're adding it...

juliangb’s picture

juliangb commented
Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)

Fine to reopen once we know which bug this fixes!