I'm getting a whole slew of errors when I load the add application page:

# Notice: Undefined property: stdClass::$secret in fb_app_edit_form() (line 122 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_app.admin.inc).
# Notice: Undefined index: fb_connect in fb_connect_form_alter() (line 641 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_connect.module).
# Notice: Undefined variable: node in fb_connect_form_alter() (line 648 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_connect.module).
# Notice: Trying to get property of non-object in fb_connect_form_alter() (line 648 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_connect.module).
# Notice: Undefined index: fb_user in _fb_user_get_config() (line 63 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).
# Notice: Undefined index: new_user_rid in fb_user_form_alter() (line 388 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).
# Notice: Undefined index: not_logged_in_uid in fb_user_form_alter() (line 396 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).
# Notice: Undefined index: logged_in_uid in fb_user_form_alter() (line 403 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).

I'll take a look and report back if I can track anything down.

Comments

tstackhouse’s picture

Notice: Undefined property: stdClass::$secret in fb_app_edit_form() (line 122 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_app.admin.inc).

This is fixed by adding 'secret' to the initialization of the blank app on line 57.

tstackhouse’s picture

# Notice: Undefined index: fb_connect in fb_connect_form_alter() (line 641 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_connect.module).

This appears to be an unused call in this function. Commenting it out appears to fix it.

tstackhouse’s picture

# Notice: Undefined variable: node in fb_connect_form_alter() (line 648 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_connect.module).

This line references $node, making it reference $fb_app instead fixes this error.

tstackhouse’s picture

# Notice: Undefined index: fb_user in _fb_user_get_config() (line 63 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).

There was a condensed conditional on this line that should read:

$fb_user_data = isset($fb_app_data['fb_user']) ? $fb_app_data['fb_user'] : array();

tstackhouse’s picture

# Notice: Undefined index: new_user_rid in fb_user_form_alter() (line 388 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).
# Notice: Undefined index: not_logged_in_uid in fb_user_form_alter() (line 396 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).
# Notice: Undefined index: logged_in_uid in fb_user_form_alter() (line 403 of /Users/tstackhouse/Sites/drupal/sites/all/modules/fb/fb_user.module).

These all reference the data returned by the conditional in _fb_user_get_config on line 63 above. Replacing 63 with these 2 lines resolves the problem:

$fb_user_defaults = array('new_user_rid' => NULL, 'not_logged_in_uid' => NULL, 'logged_in_uid' => NULL);
$fb_user_data = isset($fb_app_data['fb_user']) ? $fb_app_data['fb_user'] : $fb_user_defaults;

tstackhouse’s picture

Status: Active » Needs review

My prior comments appear to address all the errors I described, not sure how to roll a multi-file patch, otherwise I would submit one.