I think the point of the module is to easily move away from multiselect boxes, but I have them in my design spec. It would be nice to have the ability to Select All/None for the default multiselect option boxes as well.

Note: Presently I still gain mileage from this nice module in just being able to elegantly add Description/Help text under the boxes. Thanks for the good helper!

CommentFileSizeAuthor
#5 853340-2010-09-14-dev.patch10.76 KBmikeker
#2 853340.patch11.1 KBmikeker
#1 853340.patch7.78 KBmikeker

Comments

mikeker’s picture

mikeker commented
Status: Active » Needs review
StatusFileSize
new 853340.patch7.78 KB

Sorry about the super-delayed reply on this issue, it kinda fell off my radar for a while.

I've attached a patch that adds the select all/none link for any multiple-option filter ("Force single" is unchecked). I haven't had a chance to test it other than to run the patch against BEF's SimpleTest tests so having a few folks try it out would be great.

Thanks.

mikeker’s picture

mikeker commented
StatusFileSize
new 853340.patch11.1 KB

Oops. This patch includes support for Views 3.x.

texas-bronius’s picture

texas-bronius commented

Hi Mike- I have been anxious to give this patch a test drive, but maybe I've fallen out of the dev cycle.. I try to apply the patch to 6.x-1.x-dev) and get:

$ patch -p0 < 853340_0.patch
patching file better_exposed_filters_exposed_form_plugin.inc
patching file better_exposed_filters.js
Hunk #1 FAILED at 7.
Hunk #2 succeeded at 55 (offset -15 lines).
1 out of 2 hunks FAILED -- saving rejects to file better_exposed_filters.js.rej
patching file better_exposed_filters.module
Hunk #1 FAILED at 86.
Hunk #2 FAILED at 118.
Hunk #3 FAILED at 160.
3 out of 3 hunks FAILED -- saving rejects to file better_exposed_filters.module.rej

Note: I assume I should be testing with the _0 "includes support for Views 3" even though I'm on Views 2, right?

I'm not sure what to do with the fallout, so I will revert my own testing back to normal dev (6.x-1.0) and move on until further word. If you would like more eyes on this, please let me know whether I did something wrong or whether the patch is just out of date... If the patch was already rolled into 1.x-dev, then I didn't see any changes in Views UI nor in the executed View before or after the failed patch.

Thanks
-Bronius

mikeker’s picture

mikeker commented

Sorry, -dev has moved on a bit since this patch was rolled. I'll roll new patches tomorrow against dev and the 1.0 release.

mikeker’s picture

mikeker commented
StatusFileSize
new 853340-2010-09-14-dev.patch10.76 KB

Attached is a patch against the current -dev release. Tested briefly with Views 2.x but it should work with Views 3.x as well. Sorry, don't have time at the moment to roll a patch against the 1.0 release. Hopefully later...

Most of the changes are in the JS so it would be great if someone who uses AJAX-based Views and other JS-related tricks (such as instant filters or the Views Hacks module) can give this a whirl to make sure nothing broke.

Thanks.

texas-bronius’s picture

texas-bronius commented

Ok! #5 patch applies against current dev, and my tests show that it works for what I tested:

  • multiple select lists
  • one checkbox list and one multi-select default list (both with and without this select all function in all configurations)
  • every bullet list needs at least three items..

I did not (nor plan to) test any fancy ajax stuff @mikeker mentioned. If you merge it into a release, folks can just open a bug report if they come across issues in fancier applications.. (my self-serving investment of two cents)

Thanks!

mikeker’s picture

mikeker commented
Issue summary: View changes
Status: Needs review » Closed (won't fix)

Issue queue cleanup... I'm sorry for taking so long to get back to this issue! Kinda fell off my radar... Again.

At this point the 6.x release is nearing end-of-life so I'm not spending any time supporting it. If someone out there wants to continue supporting the 6.x branch of BEF, please contact me via my Drupal.org contact form about commit access.