If we use a textarea, we'll have to deal with newlines. The widget already has issues with newlines since it only shows the first line and does not stop editing upon carriage return as do the other text fields (alt, title).

Also, FileField uses a textfield for the description, so we probably want to use the same.

CommentFileSizeAuthor
swfupload-description-textfield.patch638 bytesDavid Lesieur

Comments

eugenmayer’s picture

eugenmayer commented

sounds like a reason. the question in place is, should we support multiline rather or go back to a textfield like this patch supposes?

David Lesieur’s picture

David Lesieur commented

It would be more consistent with FileField to NOT support multiline.

nicostabile’s picture

nicostabile commented

I think that a description is larger than a title for example, so multiline is necessary. You are right about that filefield not support multiline but in my opinion is a mistake because a description in most of systems needs a multiline support.

Thanks for this module, is excellent.

Best Regards,

Nicolás.

David Lesieur’s picture

David Lesieur commented

I agree that multiline descriptions would be useful. However, I think we should strive for compatibility with FileField. If we want multiline descriptions, we need to change FileField first.

The core upload module is also limited to one-line descriptions.

David Lesieur’s picture

David Lesieur commented
Version: 6.x-2.0-beta6 » 6.x-2.0-beta7

Patch still applies cleanly to beta7.

skilip’s picture

skilip commented
Status: Needs review » Reviewed & tested by the community

Sounds reasonable to me as well. We'll port this in the next release

skilip’s picture

skilip commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.