Needs review
Project:
Menu Block
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
14 Jul 2010 at 01:03 UTC
Updated:
8 Mar 2013 at 06:32 UTC
Jump to comment: Most recent file
Comments
Comment #1
johnalbinYep, this is on my radar. :-)
Comment #2
richsky commentedWell, I'm wondering if it could allow me to use a unique id on the
<ul>of my choice...since
Comment #3
johnalbinUnfortunately, there's a convoluted dependency for implementing this.
The recent Menu position modules uses a tricky pre-cache strategy of building and caching the menu tree before core or Menu block module requests it. Its completely hacky, but works in both D7 and D6.
If we implemented menu_build_tree in the 7.x-2.x branch of Menu block, menu position module would no longer work since it only works with root-level trees and not sub-trees.
The patch at #520106: Allow setting the active menu trail for dynamically-generated menu paths. would allow Menu position to dump its pre-cache strategy and start using those new APIs. Which would free up Menu block to use the menu_build_tree() functions. Since the patch isn't in Drupal 7.0, I'll have to roll a Menu block 7.x-2.0 without it. Moving to the 7.x-3.x branch.
Marking this as critical, since its blocking my plans to prepare parts of Menu block for Drupal 8.
Comment #4
johnalbinComment #5
johnalbinThis is unblocked now that Drupal 7 has finally fixed #520106: Allow setting the active menu trail for dynamically-generated menu paths..
Comment #6
eärendil commentedHere is a possible use of the menu_build_tree function in the module to help build the tree. I have attached a patch for review, but be careful as the code is still in development.
Comment #7
johnalbinRe-rolled #6 after #1937038: Use $max_depth parameter of menu_tree_all_data() and menu_tree_page_data() was committed.