Anonymous variable should be always translatable
Also: all ready -> already

CommentFileSizeAuthor
#4 853672-masq.patch632 bytesandypost
masq-strings-d6.patch2.14 KBandypost

Comments

afreeman’s picture

afreeman commented
Status: Needs review » Reviewed & tested by the community

Looks good, didn't break anything in testing.

deekayen’s picture

deekayen commented
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to DRUPAL-6--1 branch.

deekayen’s picture

deekayen commented
Version: 6.x-1.x-dev » 7.x-1.x-dev

I tried to apply this by hand to HEAD, but none of the hunks exist. Leaving open in case they're in another to-be-ported patch.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new 853672-masq.patch632 bytes

D7 does not have watchdog() call so I add this. Also user_load() used to retrive user's name so I think there's no need to get it from variable

deekayen’s picture

deekayen commented
Status: Needs review » Fixed

Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit 666eb27 on master, 8.x-2.x, 8.x-2.x-admin-menu, 8.x-1.x-1836516 by deekayen: 
    #853672 by andypost: fix some strings (partial)
  • Commit 981439b on master, 8.x-2.x, 8.x-2.x-admin-menu, 8.x-1.x-1836516 by deekayen:
    #853672 by andypost: log invalid masquerading

  • Commit 666eb27 on master, 8.x-2.x, 8.x-2.x-admin-menu, 8.x-1.x-1836516 by deekayen: 
    #853672 by andypost: fix some strings (partial)
  • Commit 981439b on master, 8.x-2.x, 8.x-2.x-admin-menu, 8.x-1.x-1836516 by deekayen:
    #853672 by andypost: log invalid masquerading