Hello,

I realized that using both the object and iframe method for the rlogin block on an external website redirects the user to the drupal website inside the object/iframe of the login form. Is it normal or is this problem associated to the other issue I've posted #853764: Error messages after module installation and "access denied" message after logout throughout the whole site ?

Thank you very much for your time and work on this module.

Stefan

Comments

Chris Johnson’s picture

Assigned: Unassigned » Chris Johnson
Chris Johnson’s picture

The rlogin module outputs HTML which contains <base target='_top' /> which should result in any link or form submission targeting "_top" or the entire window. In my tests, this correctly breaks out of any object/iframe.

The <base> element has been part of HTML for such a long time, I didn't worry about cross-browser compatibility. However, now that you report this problem, I started testing other browsers.

This works correctly on:
* Safari 4
* Safari 5
* Google Chrome 5

This fails on:
* Camino 2
* Firefox 3
* MSIE 6 (which also fails completely on <object> embedding as well, must use <iframe>)

I don't have access to MSIE 7 or 8 at the moment. I will look at finding more portable solutions.

Chris Johnson’s picture

Status: Active » Fixed

Ok, this should be fixed in CVS revision 1.2 of all of the files. It's actually just one line of added code in the rlogin.module, which adds a target="_top" attribute to the Drupal Forms API (FAPI) generated login form. Hopefully this will handle all common browsers out there.

I tested it on Safari 5, Camino 2, Firefox 3 and MSIE 7, and it worked in those browsers.

I will make a new release package for downloading soon, which will incorporate this fix.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit a62c3dc on 6.x-1.x, master, 7.x-1.x by Chris Johnson:
    bug #853796 by Chris Johnson: fix problem with breaking out of iframe to...