Make the menu parent an i18n_variables [#854228]

Hi - I really like this module. I'm using it on an i18n site _ and before you send me to the 130+ replies thread - I tend to use a separate menu for each language rather than the i18nmenu module. I fin it easier and less confusing for the user.
My request would be to make it possible to add taxonomy_menu_vocab_parent to the i18n_variables array and make it language dependent that way.
So what it needs is adding an ID for the vocabulary (and repeating that for all uses). I might take a look at patching it myself...

Comment	File	Size	Author
#2	taxonomy_menu.database.inc-localize_terms.patch	3.16 KB	miiimooo
#2	taxonomy_menu-localize_terms.patch	572 bytes	miiimooo

Comments

Comment #1

indytechcook commented 14 July 2010 at 23:47

@miimooo, I'd be happy to commit a patch. With out research, I wouldn't know where to start (though I'm sure I'd start in the i18n documentation).

Let me know if you need help in the patch or just give me a hook or something to implement and I can write the code.

Comment #2

miiimooo

Europe

commented 15 July 2010 at 11:15

Status	File	Size
new	taxonomy_menu-localize_terms.patch	572 bytes
new	taxonomy_menu.database.inc-localize_terms.patch	3.16 KB

Thanks for offering to help. Guess what I should have looked at the code first as it seems that it is already possible because the variables get saved with the vid at the end. What I've tried is adding these two to my settings.php

$conf['i18n_variables'] = array(
...
  'taxonomy_menu_vocab_parent_2',
  'taxonomy_menu_vocab_menu_2',
);

2 is the vid of my vocabulary. Now it stores one value per language.

Then I realized that on each update the menus would get overwritten so I made some changes which basically add a language column to the taxonomy_menu table and support for setting that correctly.
Also, the term itself needed translating so there is a tiny patch to taxonomy_menu.module which might break other modes of doing i18n menus but works well for my use case.

Comment #3

miiimooo

Europe

commented 15 July 2010 at 11:36

Status:

Active

» Needs review

Comment #4

indytechcook commented 22 July 2010 at 20:09

Can anybody test this?

Comment #5

miiimooo

Europe

commented 6 August 2010 at 12:40

It's working well here. Please note that it only supports one way of doing multi-lingual menus which is using a separate menu for each language. I think it would break i18n_menu.

Comment #6

agoradesign commented 1 February 2012 at 08:44

Hi,
I have the same problem / feature wish: I'm running a D7 site with i18n and Taxonomy Menu.

The terms don't get their own menu, instead they will be placed in the 2nd level of the main menu. Their parent menu item should be "products" in English and "Produkte" in German. But unfortunately this constellation is impossible to configure.

It would be nice to either have the possibility either to select an parent menu item for each language (as described by miiiooo) or even better to automatically select the right parent menu item determined by its language with the help of the translation set.

So, after line 587 (I'm using the latest dev)
$plid = variable_get(_taxonomy_menu_build_variable('vocab_parent', $item['vid']), NULL);
In theory, we should check the existence of the necessary i18n module(s) (i18n_menu??? i18n_translation???) and get the translated menu item. Unfortunately I'm quite unsure how to establish this...

For the current project I "solved" my problem with an ugly hardcoded id-based check, but it would be nice, if there would exist a common solution...

PS: I was not sure, if I should open a new issue because of the version difference (D6 vs D7)