Enhance module to “force” user to select a group upon registration

Sorry to say, it doesn’t.

The $form carries entire data in og_user function, however it's empty at og_mandatory_group_user. I guess I’d expected the $form to have the same "behavior". Am I missing something?

This is the new, not-working, code I merged (in bold):

function og_mandatory_group_user($op, &$edit, &$account, $category = NULL) {

if(!module_exist('og')){
return;
}

switch ($op) {

case 'register':
$form['og_register']['og_register']['#validate'] = array('og_mandatory_group_registration_validate' => array());
break;

case 'insert':

function og_mandatory_group_registration_validate($form_id) {
if (count($form_id['#value']) == 1 && ($form_id['#value'][0] == 1)) {
form_set_error('og_register',"You must join at least one group");
}

Clarification for the above comment: og_mandatory_group_registration_validate function is not even reached.

Yes I did. It didn't work.

I omitted the $form_values, $form from the validation function definition as in og module it pop ups some alarms. Anyway, it’s nice to see that we are making a progress.

I checked the patch and it seems to work.
I added check for zero groups, and zero groups at the registration form. It seems to work as well (in bold).

case 'register':

$group = db_fetch_object(db_query(db_rewrite_sql('SELECT n.nid, n.title, o.* FROM {node} n INNER JOIN {og} o ON n.nid = o.nid WHERE n.type IN ('. str_pad('', count(variable_get('og_node_types', array('og'))) * 5 - 1, "'%s',") .') AND o.register = 1 ORDER BY n.title'), variable_get('og_node_types', array('og'))));
if ($group != 0) {

$form['#validate'] = array('og_mandatory_group_registration_validate' => array());
$form['og_register']['minimum'] = array ('#value' => t('You must join at least one group.'),);
return $form;
}
break;

oops, just noticed patch #2. I tested #1.

I’ve tested patch #2. Seems to work. I added non-groups and empty groups at registration form checks.

case 'register':
      $group = db_fetch_object(db_query(db_rewrite_sql('SELECT n.nid, n.title, o.* FROM {node} n INNER JOIN {og} o ON n.nid = o.nid WHERE n.type IN ('. str_pad('', count(variable_get('og_node_types', array('og'))) * 5 - 1, "'%s',") .') AND o.register = 1 ORDER BY n.title'), variable_get('og_node_types', array('og'))));
      if ($group != 0) {
        $form['og_register']['minimum'] = array ('#value' => t('You must join at least one group.'),);
        return $form;
      }
      break;

I believe you need the query to avoid the wording instruction “You must join at least one group." on the screen. If you won’t query, you’ll get the wording though no group is populated at the registration form.

Sure, but as we have a working code in place, I rather keep it.

1. Well … if the mandatory group is in the form, I’d recommend its checkbox to be checked without the user ability to clear it.

2. The “Require new users to join at least one group in addition to any mandatory group” checkbox / feature doesn’t work when mandatory group (at setting) is NOT selected.
I believe two changes are needed:
a. following code in og_mandatory_group_form_alter ($form_id, &$form) function might be nested one unnecessary level, and $form['og_mandatory_in_form'] should not be cleared.

$form['og_mandatory_in_form'] = array('#type' => 'value', '#value' => FALSE,);
           if ($group_count > 0 && variable_get('og_mandatory_additional_group', FALSE)) {
             $form['og_register']['minimum'] = array ('#value' => t('You must join at least one group.'),);
           } 

I believe it should be:

/**
 * Implementation of hook_form_alter
 * 
 */
function og_mandatory_group_form_alter ($form_id, &$form) {
  if ($form_id == 'user_register') {
    unset($form['og_register']['og_register']['#options'][0]); //temporary fix
    
    $group_count = count($form['og_register']['og_register']['#options']);
    if ($mandatory_group = variable_get('og_mandatory_group', 0)) {
       if (in_array($mandatory_group, array_keys($form['og_register']['og_register']['#options']))) {
         $form['og_register']['og_register']['#options'][$mandatory_group] .= ' ('. t('This group is mandatory'). ')';
         $form['og_register']['og_register']['#default_value'] = array($mandatory_group);
         $form['og_mandatory_in_form'] = array('#type' => 'value', '#value' => $mandatory_group,);
         if ($group_count > 1 && variable_get('og_mandatory_additional_group', FALSE)) {
           $form['og_register']['minimum'] = array ('#value' => t('You must join at least one additional (non-mandatory) group.'),);
         }
       }
    }
    // REMOVED $form['og_mandatory_in_form'] = array('#type' => 'value', '#value' => FALSE,);
    // EXTRACT FROM ABOVE IF
    if ($group_count > 0 && variable_get('og_mandatory_additional_group', FALSE)) {
      $form['og_register']['minimum'] = array ('#value' => t('You must join at least one group.'),);
    }
  }
}

b. Next code (in validate case of og_mandatory_group_user function) is not been reached, which allow the user to register even though a group was not selected (and mandatory group in NOT selected at setting).

if (count($edit['og_register']) > 0 && count(array_filter($edit['og_register'])) < 1) {
            form_set_error('og_register', "You must join at least one group");
          }

3. I think that we should offer two modes, and consider if a third one is necessary:
a. only mandatory group (already supported).
b. only join-at-least-one (need above bug fix).
c. mixed (personally, I’m not sure if it will have a demand).

4. In setting: if mandatory group is selected, then it’s not possible to disable the mandatory group, and only enable the “Require new users to join at least one group in addition to any mandatory group” without going through the “reset to default”

The “none” is a very good option, however I suggest separating the mandatory group and join-at-least-one to two distinct configuration blocks. As it stands, the “none” looks as it pertains to the “Require new users to join …” checkbox as well.
May I suggest the following code at og_mandatory_group_settings():

  if (count($options)) {
    $options = array_merge(array(0 => theme('placeholder', t('none'))), $options);
    $form['og_mandatory_group_setting_block'] = array(
      '#type' => 'fieldset', '#title' => t('Mandatory Group settings'),
      '#collapsible' => FALSE, '#collapsed' => False
    );
    $form['og_mandatory_group_setting_block']['og_mandatory_group'] = array(
      '#type' => 'radios', 
      '#options' => $options, 
      '#default_value' => variable_get('og_mandatory_group', 0),
    );
  }
  $form['join_at_least_one_group_setting_block'] = array(
    '#type' => 'fieldset', '#title' => t('Join at least on Group settings'),
    '#collapsible' => FALSE, '#collapsed' => False
  );
  $form['join_at_least_one_group_setting_block']['og_mandatory_additional_group'] = array(
      '#type' => 'checkbox', 
      '#title' => t('Require new users to join at least one group in addition to any mandatory group'),
      '#default_value' => variable_get('og_mandatory_additional_group', FALSE),
    );
  return $form;

Second, it seems that the mandatory group is not working. The “if” condition at og_mandatory_group_form_alter () does not yield true

if (in_array($mandatory_group, array_keys($form['og_register']['og_register']['#options']))) {

O yeah. Looks much better, though it’s kind of late now, and I haven’t had the chance to thoroughly test it. But, at first glace, it looks very good.

One feel&look issue: the checked checkbox of the mandatory group at registration form is too mild, hardly can be seen. I tested in all four themes that comes with Drupal, and a few others, all of which the checkbox can hardly been seen as checked. It would be nice if there is an option to “bold” the "v" sign.

Looks good to me.
Please let me know upon upgrading the module, as I like to use this feature.

Ok, 1 2 3, testing, testing …

The organic group mandatory module is happy to announce a new feature; supports an option which obliged the end user to join at least one group during registration.

Usage: say you’ve established moderated groups, and populate them into the registration form: if you want to force a new user to join at least one group, then this is your lucky day.

Yes - thanks you very much :)
I’m content.

Emek
http://www.sadot.tv