hook_notifications_message_alter() never called because method message_build() should be renamed build() [#854580]

Hello,

For the module notifications_files to work, the notifications_message hook must be called by the notifications modules but is never called. In last dev version, the hook is called from the message_build() method, but in the last version of class herited from the messaging module 6.x-4.0-beta6, the method should be renamed only build to be called. See attached patch.

Best regards.

Guillaume

Comment	File	Size	Author
	notifications_message.class_.inc_.build_.patch	867 bytes	Barberousse

Comments

Comment #1

danepowell commented 28 August 2010 at 22:25

Title:	notifications_message hook never called because method message_build() should be renamed build()	» hook_notifications_message_alter() never called because method message_build() should be renamed build()
Priority:	Normal	» Major

Haven't tested the patch yet, but I can confirm that hook_notifications_message_alter() is not being called, and this completely breaks notifications_files-6.x-4.x, so I am marking this as major. Corresponding issue in NF queue: #853308: No files sent with Mimemail sending method

Barberousse I changed the title to match, is this an accurate description of the problem? Thanks for doing the legwork on this.

Comment #2

danepowell commented 28 August 2010 at 22:30

Status:

Active

» Reviewed & tested by the community

Okay, I did test the patch and it solves the problem- however, I'm not familiar with the 4.x architecture so I don't want to commit this myself, I'd rather Jose check off on it