Here is a patch for the dev nightly build from July 11, 2010 to reformat the views_views_xml_style.theme.inc code according to the Drupal style guide (http://drupal.org/coding-standards). I also swapped out a few series of if/else statements for switch/case statements where is made sense and it made the code cleaner and easier to read. Please review.

Thanks
Dale

CommentFileSizeAuthor
#2 xml_style_formatting_2.patch30.14 KBd.clarke
#1 xml_style_formatting.patch30.45 KBd.clarke

Comments

d.clarke’s picture

d.clarke commented
StatusFileSize
new xml_style_formatting.patch30.45 KB

I'd forgotten to attach the patch... here is the patch file for the nightly dev build from July 11, 2010. I'm updating it now to include the changes committed today and will post an updated version shortly.

d.clarke’s picture

d.clarke commented
StatusFileSize
new xml_style_formatting_2.patch30.14 KB

Here is a version of the patch that applies against the current 6.x-1.x-dev CVS state.

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Category: support » bug

Hey Dale, just trying to help out cleaning the issue queue here. Switching it to a bug report since support requests serve more as a Q&A rather than place to post patches.

If you want, you can apply to help Bálint (Pasqualle) with the 6.x branch. He just became a maintainer, but I think he'll be mostly focusing on the 7.x branch. He stated that:

If somebody would like to help maintain the module then please
- help with cleaning up the issue queue. if you can answer a support question, then please just do it
- post any problems with the module
- post patches, solutions or code snippets
- create documentation pages
I will give you permissions if you ask for it and when I see you are really helping with the module.

zeip’s picture

zeip commented
Issue summary: View changes
Status: Needs review » Closed (outdated)

Drupal 6 has been EOL for some years, closing all D6 issues.