This is going to be an overview issue for smaller NEWLINE (no other problems) patches.
Marking this already as duplicate.
List with patches will follow soon.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 855170.patch | 42.71 KB | amateescu |
This is going to be an overview issue for smaller NEWLINE (no other problems) patches.
Marking this already as duplicate.
List with patches will follow soon.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 855170.patch | 42.71 KB | amateescu |
Comments
Comment #1
aspilicious commentedHere is a start. Marking this back active so I can find this issue in my issue queue more easily
#855184: Fix newlines in authorize.inc
#855178: Fix newlines in archiver.inc
#855176: Fix newlines in actions.inc
#855248: Fix newlines in batch.inc
#855250: Fix newlines in bootstrap.inc
#855254: Fix newlines in cache.inc
#855258: Fix newlines in common.inc
#855308: Fix newlines in error.inc
#855310: Fix newlines in file_mimetype.inc
#855314: Fix newlines in form.inc
#855316: Fix newlines in image.inc
#855322: Fix newlines (and some dots) in locale.inc
#855324: Fix newlines in install.inc
#855374: Fix newlines in lock.inc
#855376: Fix newlines in mail.inc
#855378: Fix newlines in menu.inc
#855386: Fix newlines in module.inc
#855390: Fix newlines in path.inc
#855394: Fix newlines in session.inc
#855400: Fix issues in theme.inc - newlines and missing doc
#855402: Fix newlines in token.inc
#855406: Fix newlines in unicode.inc
#855410: Add missing doc and newlines in updater.inc
#855414: Fix newlines in utility.inc
#855418: Fix doc errors in xmlcpr.inc and fill in the missing doc headers
#855420: Doc cleanup for xmlrpcs.inc and add missing doc headers
#855684: Fix newlines in filetransfer.inc
#855688: Fix newlines in ftp.inc
Comment #2
jhodgdonDries requested on #855324: Fix newlines in install.inc (comment #11) that we combine all the "fix newlines" issues into one patch.
Webchick suggested on #855410: Add missing doc and newlines in updater.inc (comment #7) that a better approach would be to write a script.
So let's leave this issue open, and close the others as duplicates. The idea is to write a script that would fix all the docblocks so that they have a blank line between the @param section and the @return. Or, even simpler, so that there is a blank line before the @return in each docblock.
Comment #3
amateescu commentedHow about some good old find/up arrow/enter for a start? :)
Not marking CNR because i don't want to stress the test bots with this patch.
Comment #4
jhodgdonThe patch looks reasonable (at least at first skim) for includes/*.inc, but we actually do want a script, and there are more files in modules/* for instance that need this change.
Does the Coder module have a test/fix for this? If so, maybe we can leverage that?
Comment #5
alexander allen commentedHow about a regex in Zend Studio file search?
Comment #6
jhodgdonDoes Zend Studio do search *and replace* with a regexp? I don't know if that's acceptable anyway. The objective would be to have something anyone can run, and not everyone has Zend.
How about a PHP or shell script, or better yet, a patch to the Coder/Coder Update module?
Comment #7
jhodgdonWe are doing a doc sprint to fix this up along with some other docs problems. So closing this as a duplicate of
#1310084: [meta] API documentation cleanup sprint