Use CTools' export-ui

Subscribing to keep track so that this doesn't get lost :)

The export UI is currently working in 3.x-dev

This is not in Services 3.x - restoring status.

Soo, bumping this to 7.x

We now have a feature branch located here, http://drupalcode.org/project/services.git/shortlog/refs/heads/master-ct...

I have started moving this over AND updating the UI saving resources.

Interesting, subscribing

Ok, heres a new patch, needs review.

This updates Services to use ctools export UI.

Eek, updated patch

I haven't tested this patch functionally but from a eyeballing we are missing doxygen in a number of place and some @param values are missing types. Yes I realise this is a nip pick in some ways but documented code is good code ;)

Ok, heres updated patch with some more comments.

Here is same patch without trailing spaces. I will do more precise review with corrections in #1096316: Resource UI is lacking a good UX

after installing module I get error:

Notice: Undefined variable: items in services_menu() (line 95 of /var/www/services/d7/sites/all/modules/services/services.module).

Here is amended patch to fix this problem.

Added hook_requirements to check version of CTools.

Some more comments after trying this out.

- I don't understand why we need both a 'Name' and a 'Endpoint Name' when creating a new endpoint. They are both supposed to be unique so what's the point?

- When I create a new endpoint and enter 'test' for all fields, REST as server, and click either 'Save' or 'Save and proceed' I get the following PDO error, although the endpoint does actually get created. This also happens if you Clone or Import an endpoint.

PDOException: SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1' for key 'PRIMARY': INSERT INTO {services_endpoint} (eid, name, title, server, path, authentication, resources, debug) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2, :db_insert_placeholder_3, :db_insert_placeholder_4, :db_insert_placeholder_5, :db_insert_placeholder_6, :db_insert_placeholder_7); Array ( [:db_insert_placeholder_0] => 1 [:db_insert_placeholder_1] => test [:db_insert_placeholder_2] => test [:db_insert_placeholder_3] => rest_server [:db_insert_placeholder_4] => test [:db_insert_placeholder_5] => a:0:{} [:db_insert_placeholder_6] => a:0:{} [:db_insert_placeholder_7] => 0 ) in drupal_write_record() (line 6774 of /Users/gdd/htdocs/services_7/includes/common.inc).

- What is the difference between 'Save' and 'Save and Proceed'?

- When I go to edit a service I have two Save buttons.

- When saving the Resources page I get the following notice

Notice: Trying to get property of non-object in services_endpoint_save() (line 268 of /Users/gdd/htdocs/services_7/sites/all/modules/services/services.module).

- Didn't we used to have a List tab so you could get back to the endpoint index without going to the breadcrumb?

So for the record, I just tried #17 out with a fresh install, a new checkout of the 7.x-3.x branch, and alpha3 of CTools, and I am still getting these same results.

Updates CTOOLs patch

Fixes tests, Resources page errors, Various Submit buttons, and rollls all the previous patches into one.

I have enabled services module only on fresh install. When I try to create endpoint I don't have any choice in Server selecbox (that is right as I haven't enabled any servers). But when I submit and get validation error I also have error
Warning: implode() [function.implode]: Invalid arguments passed in form_error() (line 1576 of /var/www/services/d7/includes/form.inc).
I also get this error when enable rest server and create endpoint (no validation errors).

I have managed to create endpoint with name that has spaces and capital letters. I believe this should be impossible. But in my case validation accepted this.

I have also tried to export / import endpoint. This worked fine.

What is really needed is to have validation on path as I exported / imported same endpoint with change of name but not changing path. So it happened to exist two endpoints with same pathes.

Updated patch address issues in #21

After I import the endpoint I can't save it. I get all the time error
The export id can only consist of lowercase letters, underscores, and numbers.
Screenshot: http://skitch.com/ygerasimov/rsqea/selection-014

This happened after I named endpoint with capital letters, exported it and tried to import.

IM not able to reproduce this :(

Ok, this seems to be a CTOOLs bug, ill open a patch over there when I get to one, but theres a new patch to be applied to 7.x-3.x

OK, heres a patch that should fix the Uppercase issues. Endpoint names must follow ctools primary key naminving convention of lowercase 0-9 and underscores.

Works much better. I haven't found any bugs.

Set to RTBC

Gonna let hejrocker do one more pass, then Ill commit.

I have some concerns about services_edit_form_endpoint_resources_submit as there are variable names such as $c being used. I simply can't tell what on earth is going on that function because we don't have meaningful names.

Is this code correct

if (!empty($rop['endpoint']['preprocess'])) {
+      $settings['preprocess'] = array(
+        '#type' => 'item',
+        '#title' => t('Preprocess function'),
+        '#value' => $rop['endpoint']['preprocess'],
+      );
+    }
+
+    if (!empty($rop['endpoint']['postprocess'])) {
+      $settings['preprocess'] = array(
+        '#type' => 'item',
+        '#title' => t('Postprocess function'),
+        '#value' => $rop['endpoint']['Postprocess'],
+      );
+    }

As we are setting preprocess in both cases.

Looks like we have a typo.

'title singular proper' => t('Endppint'),

Do we need dynamic queries in services_ctools_export_ui_form_validate or can we just use dbquery with placeholder? I think we can but I'm not 100% certain.

Can we do an isset rather than checking for key exists as this is more performant

 if(is_array($endpoint) && array_key_exists('build_info', $endpoint)) 

Updated patch fixing marcingy's comments

Woops, updated patch, my bad

hers 6.x version of the ctools update