There's a useless span after link which produces not valid html

Comments

Status: Needs review » Needs work

The last submitted patch, pm-valid-html-d7.patch, failed testing.

andypost’s picture

Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs work » Needs review
StatusFileSize
new1.08 KB

Trying it for D7

andypost’s picture

Version: 7.x-1.x-dev » 6.x-1.x-dev
StatusFileSize
new1.78 KB

Now for d6

berdir’s picture

That span is there for a reason. You need to ask Michelle about how it works exactly, but we can't just remove it, that is going to break stuff.

michelle’s picture

Just stumbled on this and, honestly, I'm not sure. Obviously it's not a simple typo so there was a reason when it was put in but I can't see a reason for it now. I'm guessing it had to do with the image handling because that's handled elsewhere with spans but, in this case the image handling is on the main class itself. I'm working on the AP integration with both versions of AF right now and will throw looking into this into the mix.

Michelle

andypost’s picture

@Michelle I think jQuery should add this span while processing with http://api.jquery.com/append/ or similar to leave code valid.
Anyway thanx for review

berdir’s picture

Status: Needs review » Fixed

Asked Michelle and she just removed the same from another module and said that it is not required anymore. Applied the patches to all branches, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.