The standard Drupal convention is to use singular names for all tables (e.g., {node}, {role} - there are exceptions in core, but each with specific reasons). We violate this, and should fix it.

Not pressing, though.

Comments

marvil07’s picture

marvil07 commented
Priority: Normal » Minor

Ok as official docs, but this is going to be a medium patch :-p

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Assigned: Unassigned » cweagans

Taking this.

cweagans’s picture

cweagans
He/Him
Primary language English
Location Boise, ID, USA
commented
Assigned: cweagans » Unassigned

Okay, just kidding. Not tonight.

marvil07’s picture

marvil07 commented
Priority: Minor » Major

moving to major, since it's a db change, and I think it would be great to avoid db changes after the 2.0-RC1

marvil07’s picture

marvil07 commented
Issue tags: +git phase 2, +git sprint 4

not confirmed for sprint 4, but tagging to avoid forgetting about it

sdboyer’s picture

sdboyer commented
Issue tags: -git sprint 4

yeah, we've got other more critical stuff for sprint 4, untagging.

marvil07’s picture

marvil07 commented
Status: Active » Postponed

I am postponing this until #879858: Unify entity C(R)UD and #879600: Meta: introduce an activity stream separate from commit logs gets in, to avoid unnecessary patches conflict.

sdboyer’s picture

sdboyer commented
Issue tags: -git phase 2 +git phase 2 leftovers

Yeah, no.

marvil07’s picture

marvil07 commented
Issue tags: +versioncontrol-6.x-2.0-release-blocker

tagging

marvil07’s picture

marvil07 commented
Issue tags: -versioncontrol-6.x-2.0-release-blocker

Since #879600: Meta: introduce an activity stream separate from commit logs is not a release blocker, and we are kind of late for a schema change like that, I move this to the next major version of versioncontrol.